Skip to content

Commit

Permalink
Fix configure logic calling configured decider not handling DeciderNe…
Browse files Browse the repository at this point in the history
…edsNode exception which can be thrown by MD5-Timestamp decider logic
  • Loading branch information
bdbaddog committed Feb 2, 2019
1 parent 48a7fdd commit 533bef1
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src/engine/SCons/SConf.py
Expand Up @@ -56,6 +56,7 @@
import SCons.Conftest

from SCons.Debug import Trace
from SCons.Node import DeciderNeedsNode

# Turn off the Conftest error logging
SCons.Conftest.LogInputFiles = 0
Expand Down Expand Up @@ -330,8 +331,14 @@ def execute(self):
# that the correct .sconsign info will get calculated
# and keep the build state consistent.
def force_build(dependency, target, prev_ni,
env_decider=env.decide_source):
env_decider(dependency, target, prev_ni)
env_decider=env.decide_source,
node=None):
try:
env_decider(dependency, target, prev_ni)
except DeciderNeedsNode as e:
e.decider(target, prev_ni, node=target)
except Exception as e:
raise e
return True
if env.decide_source.__code__ is not force_build.__code__:
env.Decider(force_build)
Expand Down

0 comments on commit 533bef1

Please sign in to comment.