setup.py does not use build_scripts, therefore lacking shebang replacement

[bdbaddog]

This issue was originally created at: 2013-02-06 03:55:07.
This issue was reported by: mgorny.
mgorny said at 2013-02-06 03:55:07

The build_scripts command of distutils replaces shebangs of installed scripts with the Python
version used to build the package. SCons does not use it but installs the scripts directly,
therefore having their shebangs left unfixed.

This results in a failure to 'plainly' run SCons on a system that has Python3 used by default:

$ scons
scons: *** SCons version 2.2.0 does not run under Python version 3.2.3.
Python 3.0 and later are not yet supported.

While proper shebang substitution would result in SCons being run with Python 2.7 (as the user
expects it to be).

I'd like to request either using build_scripts to fix shebangs unconditionally or providing an
option to do so.

alastairt said at 2013-04-29 09:22:21

Fix for scons.setup.py.

This bug occurs as self.scripts returns ['script/scons', 'script/sconsign',
'script/scons-time', 'script/scons.bat']
But this is not where build_scripts has put them.

If we look at
To mirror
/opt/lib/python2.7/distutils/command/build_scripts.py:copy_scripts

   for script in self.scripts:
       adjust = 0
       script = convert_path(script)
       outfile = os.path.join(self.build_dir, os.path.basename(script))

Thus the setup.py install_scripts should be using the paths as above.

N.B. self.scripts == self.distribution.scripts == self.get_inputs()

Patch to fix this issue.
+from distutils.util import convert_path

setup.py: line 299: install_scripts.run
-inputs = self.get_inputs()
+inputs = [os.path.join(self.build_dir, os.path.basename(convert_path(script)))
for script in self.get_inputs()]

[bdbaddog]

closing in favor of #3451