Add method for individual tools to search for windows install paths which aren't in SCons' defaults + changes to get more tests to pass on windows and/or appveyor

[bdbaddog]

Add method for individual tools to search for windows install paths which aren't in SCons' defaults.

• Updated logic for mingw and clang on win32 to search default tool install paths if not
  found in normal SCons PATH. If the user specifies PATH or tool specific paths they
  will be used and the default paths below will be ignored.
  • Default path for clang/clangxx : C:\Program Files\LLVM\bin
  • Default path for mingw : c:\MinGW\bin

Contributor Checklist:

• I have created a new test or updated the unit tests to cover the new/changed functionality.
• I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
• I have updated the appropriate documentation

[dmoody256]

mingw binaries can also be installed in cygwins paths such as:

• C:\cygwin64\bin
• C:\msys64
• C:\cygwin\bin
• C:\msys

So maybe add those to the list of default paths to find mingw binaries.

[bdbaddog]

Apparently clang also requires a msvc or msvs tool configured, or also perhaps mingw so that it can find header files via INCLUDE shell environment variable. So my fixes in this patch for clang are not sufficient.

[bdbaddog]

For clang include path initialization look at : https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/MSVC.cpp

[dmoody256]

There is a Mircosoft implementation of clang which takes MSVC compiler style flags (forward slash) which is different than the mingw clang which is like gcc style flags (dash).

Sent from my Galaxy Note5 using FastHub

[bdbaddog]

Any idea how to detect which is which?

…

On Wed, Feb 14, 2018 at 3:02 PM, Daniel Moody ***@***.***> wrote: There is a Mircosoft implementation of clang which takes MSVC compiler style flags (forward slash) which is different than the mingw clang which is like bcc style flags (dash). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3052 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFBNHhKhe1_Sar49mj-r0cs50YmB-yXks5tUzvNgaJpZM4RiYWv> .

[dmoody256]

The MSVC one is named clang-cl, more info here:
https://clang.llvm.org/docs/UsersManual.html#clang-cl

[bdbaddog]

Looks like clang-cl would still need all the environment variables set by using msvs or msvc tool in scons to function.

…

-Bill

On Wed, Feb 14, 2018 at 5:16 PM, Daniel Moody ***@***.***> wrote: The MSVC one is named clang-cl, more info here: https://clang.llvm.org/docs/UsersManual.html#clang-cl — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3052 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFBNG4wjf4qVafCGkhgnwHaw9zipY5Yks5tU1tXgaJpZM4RiYWv> .

[dmoody256]

Yeah, did you see the PR I did on this branch in your fork?

…

On Feb 18, 2018 8:19 PM, "William Deegan" ***@***.***> wrote: Looks like clang-cl would still need all the environment variables set by using msvs or msvc tool in scons to function. -Bill On Wed, Feb 14, 2018 at 5:16 PM, Daniel Moody ***@***.***> wrote: > The MSVC one is named clang-cl, more info here: > https://clang.llvm.org/docs/UsersManual.html#clang-cl > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#3052 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ AAFBNG4wjf4qVafCGkhgnwHaw9zipY5Yks5tU1tXgaJpZM4RiYWv> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3052 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF2YzDtXNZoBzO6wI2vlWmgvhMJfjclKks5tWMwMgaJpZM4RiYWv> .

[bdbaddog]

Didn't see it until now. Ugh.. Github doesn't make you automatically watch your on repos? Anyway see comments there.. On Sun, Feb 18, 2018 at 9:06 PM, Daniel Moody <notifications@github.com> wrote:

…

Yeah, did you see the PR I did on this branch in your fork? On Feb 18, 2018 8:19 PM, "William Deegan" ***@***.***> wrote: > Looks like clang-cl would still need all the environment variables set by > using msvs or msvc tool in scons to function. > > -Bill > > On Wed, Feb 14, 2018 at 5:16 PM, Daniel Moody ***@***.***> > wrote: > > > The MSVC one is named clang-cl, more info here: > > https://clang.llvm.org/docs/UsersManual.html#clang-cl > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > <#3052 (comment)>, or > mute > > the thread > > <https://github.com/notifications/unsubscribe-auth/ > AAFBNG4wjf4qVafCGkhgnwHaw9zipY5Yks5tU1tXgaJpZM4RiYWv> > > . > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#3052 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ AF2YzDtXNZoBzO6wI2vlWmgvhMJfjclKks5tWMwMgaJpZM4RiYWv> > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3052 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFBNGh-dkyJwrbKAK5fMTfhvDOuKpcfks5tWNcZgaJpZM4RiYWv> .

[coveralls]

Coverage increased (+1.08%) to 80.142% when pulling 3959c91 on bdbaddog:appveyor_issues into 992aeeb on SCons:master.

[dmoody256]

Opened bdbaddog#2 for this branch in your repo @bdbaddog

[bdbaddog]

Merging.