Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH issue #3136 No need to explicitly set file handles to non-sharable. Py 3.4 and above do this by default #3245

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Fix GH issue #3136 No need to explicitly set file handles to non-sharable. Py 3.4 and above do this by default #3245

merged 2 commits into from
Dec 10, 2018

Conversation

bdbaddog
Copy link
Contributor

@bdbaddog bdbaddog commented Nov 28, 2018 •
edited
Loading

Fix GH issue #3136 No need to explicitly set file handles to non-sharable. Py 3.4 and above do this by default

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@bdbaddog
Fix GH issue SCons#3136 No need to explicitly set file handles to non…
ac8fa00 
…-sharable. Py 3.4 and above do this by default
@coveralls
Copy link

coveralls commented Nov 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-2.2%) to 79.472% when pulling 98b8072 on bdbaddog:fix_gh_3136_py3_modified_io_class_breaks into b4d710b on SCons:master.

@bdbaddog bdbaddog changed the title [WIP] Fix GH issue #3136 No need to explicitly set file handles to non-sharable. Py 3.4 and above do this by default Fix GH issue #3136 No need to explicitly set file handles to non-sharable. Py 3.4 and above do this by default Dec 10, 2018
@bdbaddog bdbaddog merged commit f55f43e into SCons:master Dec 10, 2018
mwichmann added a commit to mwichmann/scons that referenced this pull request Aug 13, 2019
@mwichmann
[PR SCons#3245] fix sider complaint about misspelling [ci skip]
fa21790 
Signed-off-by: Mats Wichmann <mats@linux.com>
mwichmann added a commit to mwichmann/scons that referenced this pull request Sep 7, 2019
@mwichmann
[PR SCons#3245] fix sider complaint about misspelling [ci skip]
7cb3823 
Signed-off-by: Mats Wichmann <mats@linux.com>
@mwichmann mwichmann mentioned this pull request Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdbaddog @coveralls