New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run latex after bibtex/biber only when necessary #3421
Conversation
The AppVeyor fails are "known" and not caused by this PR: the swig-on-2.7 one is under investigation; the other is intermittent. |
@managan - Any chance you could take a look at this? |
Not right now. Headed off for a week of vacation and a week long meeting in Italy.
I took a brief look. Right now we start by running latex and then decide whether to run again. We would have to store info about files that exist before the run so we could compare after to see if we need to run again.
Right now it just scans produced files to see if there are bibliography data present and then flags the files as read so it does not repeat that. So yes, if there is a bibliography we run latex at least twice.
I will try and see what I can do after I get back.
...
|
github! |
@managan - Any chance you have a bit to review this PR now? |
This looks good to me. I will note that if we want to support packages that create multiple bbl files, like the chapterbib or multibbl packages, then this will need a rewrite. The current logic assumes a single bbl file that is named from the primary text file name. |
thanks @managan - So if we wanted to support packages that create multiple bbl files does the current logic (not inclusive of this patch) work? in other words are we losing the capability by merging this? |
OK,
It seems that the current system is conservative and works with packages like chapterbib. It does not clean all the files. But since it forces a run of bibtex on all the instances found in the aux file it catches changes.
So we do sort of lose capability.
Got to run so I can fill in details later.
|
@managan - Does it look like the code could be modified to avoid losing current functionality? |
@managan - Ping? Any further thoughts? |
Although comments in src/engine/SCons/Tool/tex.py indicated that latex should only be run after biber/bibtex if the .bbl file had changed, it was always run.
74baea1
to
c96a660
Compare
Although comments in src/engine/SCons/Tool/tex.py indicated that latex
should only be run after biber/bibtex if the .bbl file had changed, it
was always run.
Contributor Checklist:
master/src/CHANGES.txt
directory (and read theREADME.txt
in that directory)