Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run latex after bibtex/biber only when necessary #3421

Merged
merged 3 commits into from Jan 24, 2023

Conversation

luhk
Copy link

@luhk luhk commented Aug 4, 2019

Although comments in src/engine/SCons/Tool/tex.py indicated that latex
should only be run after biber/bibtex if the .bbl file had changed, it
was always run.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
  • No documentation to update

@mwichmann
Copy link
Collaborator

The AppVeyor fails are "known" and not caused by this PR: the swig-on-2.7 one is under investigation; the other is intermittent.

@bdbaddog
Copy link
Contributor

@managan - Any chance you could take a look at this?

@managan
Copy link
Contributor

managan commented Aug 30, 2019 via email

@bdbaddog
Copy link
Contributor

PS. How do I search the issues list on github? Or is there a better place?

github!

@mwichmann
Copy link
Collaborator

@bdbaddog
Copy link
Contributor

@managan - Any chance you have a bit to review this PR now?

@managan
Copy link
Contributor

managan commented Sep 19, 2019

This looks good to me.

I will note that if we want to support packages that create multiple bbl files, like the chapterbib or multibbl packages, then this will need a rewrite. The current logic assumes a single bbl file that is named from the primary text file name.

@bdbaddog
Copy link
Contributor

thanks @managan - So if we wanted to support packages that create multiple bbl files does the current logic (not inclusive of this patch) work? in other words are we losing the capability by merging this?

@managan
Copy link
Contributor

managan commented Sep 20, 2019 via email

@bdbaddog
Copy link
Contributor

bdbaddog commented Oct 8, 2019

@managan - Does it look like the code could be modified to avoid losing current functionality?

@bdbaddog
Copy link
Contributor

bdbaddog commented Aug 2, 2020

@managan - Ping? Any further thoughts?

@mwichmann mwichmann added the LaTex LaTex related issues. label Jan 7, 2021
Although comments in src/engine/SCons/Tool/tex.py indicated that latex
should only be run after biber/bibtex if the .bbl file had changed, it
was always run.
@bdbaddog bdbaddog merged commit 7bcef9f into SCons:master Jan 24, 2023
@mwichmann mwichmann added this to the 4.5 milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LaTex LaTex related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants