Allow Zip tool to override timestamp on included files. #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djh82
commented
Jan 13, 2021
bdbaddog
changed the title
bdbaddog
reviewed
Jan 16, 2021
bdbaddog
reviewed
Jan 16, 2021
bdbaddog
reviewed
Jan 16, 2021
bdbaddog
reviewed
Jan 16, 2021
|
A couple notes also if you can address the 1 sider issue, I can merge right away! |
|
@bdbaddog sure, will finish this tomorrow. |
|
@bdbaddog all done; not sure the failures are related?! |
|
@djh2 usually that kind of msvs failure is appveyor needs to renew the "license" in the image (even though the community edition is free to use). they expire. |
|
@djh82 - Great work here! The Appveyor fails are compiler license and so can be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)Adds ZIP_OVERRIDE_TIMESTAMP to the Zip builder. Fixes #3843.