Fix isabs() check in NodeInfo for Py 3.13 #4505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.13 (alpha) changes the behavior of isabs() on Windows. SCons has places where it does splitdrive on an absolute path, then checks if the path part is absolute - this answer is now False, which caused some interesting test fails. Do the check on the original path to get a more accurate answer. There may be more subtle issues with the Python change, but first fix the ones we can see. Simplify the setup of _my_splitdrive() a bit: every caller is supposed to check do_splitdrive but a couple of locations did not. Remove the special check for UNC support, all Python versions SCons runs on do UNC handling, so just eliminate that bit. Fixes SCons#4502, SCons#4504. Signed-off-by: Mats Wichmann <mats@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 (alpha) changes the behavior of
os.path.isabson Windows. SCons has places where it doessplitdriveon an absolute path, then checks if the path part is absolute - this answer is nowFalse, which caused some interesting test fails. Do the check on the original path to get a more accurate answer. There may be more subtle issues with the Python change, but first fix the ones we can see.Simplify the setup of
_my_splitdrivea bit: every caller is supposed to checkdo_splitdrivebefore calling, but a couple of locations did not. Remove the special check for UNC support, all Python versions SCons runs on do UNC handling, so just eliminate that bit.Fixes #4502, #4504.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)