Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentication header is not used in request after redirect #3499

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoergSiebahn
Copy link
Contributor

@JoergSiebahn JoergSiebahn commented Jun 20, 2024

This PR reproduces a reported issue that the Authentication header is lost when following 303 See Other redirects.

According the report, the behavior has changed from v5 to v6. This can be confirmed with a copy of the new test to the current state of release/5.x.x.

Copy link
Contributor

⚠⚠⚠ This pull request will not create a new release. ⚠⚠⚠

Copy link
Contributor

Test Results

1 160 files  ±0  1 160 suites  ±0   38m 52s ⏱️ +44s
1 567 tests  - 3  1 550 ✅  - 6  14 💤 ±0  3 ❌ +3 
6 633 runs  +5  6 564 ✅  - 2  63 💤 +1  6 ❌ +6 

For more details on these failures, see this check.

Results for commit 5ad6748. ± Comparison against base commit a4fc7eb.

This pull request removes 5 and adds 2 tests. Note that renamed tests count towards both.
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [4] {tenant-id=[t-c], processes=[p-c1, p-c2]}, {tenant-id=[], processes=[p-n3, p-n4]}, EXTEND, {tenant-id=[t-c], processes=[p-c1, p-c2, p-n3, p-n4]}
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [5] {tenant-id=[t-c]}, {processes=[p-n]}, EXTEND, {tenant-id=[t-c], processes=[p-n]}
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [8] {tenant-id=[t-c]}, {tenant-id=[t-n], processes=[p-n]}, KEEP, {tenant-id=[t-c], processes=[p-n]}
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [9] {tenant-id=[t-c], processes=[p-c]}, {tenant-id=[t-n]}, REPLACE, {tenant-id=[t-n], processes=[p-c]}
org.sdase.commons.server.kafka.producer.MetadataContextAwareKafkaProducerTest ‑ [4] {tenant-id=[t1]}, {something=great}, {tenant-id=[t1], something=[great]}
org.sdase.commons.client.jersey.ApiClientTest ‑ seeOtherAfterPostWithAuth()
org.sdase.commons.server.opa.testing.OpaTimeoutIT ‑ [2]

Copy link

sonarcloud bot commented Jun 20, 2024

@JoergSiebahn
Copy link
Contributor Author

JoergSiebahn commented Jun 20, 2024

The regression may be intended and required to comply with the spec. It may be caused by this issue. I'm not 100% sure, if it is the Netty connector that is internally doing the requests of the clients created here. But that change was released with 2.41 and the latest Jersey version in DW Commons 5.x.x was 2.39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant