Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address codacy issues across the project #35

Closed
michaelhglass opened this issue Apr 7, 2018 · 4 comments
Closed

Address codacy issues across the project #35

michaelhglass opened this issue Apr 7, 2018 · 4 comments
Assignees
@michaelhglass
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@michaelhglass
Copy link
Member

After the codacy integration, I suggest a round of patching all across the project.
@michaelhglass michaelhglass added enhancement New feature or request help wanted Extra attention is needed labels Apr 7, 2018
@michaelhglass michaelhglass self-assigned this Apr 7, 2018
michaelhglass added a commit that referenced this issue Apr 7, 2018
@michaelhglass
Merge branch 'patch/#35-codacy-issues' of https://github.com/felixrei…
7269723 
…mann/opt4j.git into patch/#35-codacy-issues
@coveralls coveralls mentioned this issue Apr 8, 2018
Merged
@FedorSmirnov89
Copy link
Member

FedorSmirnov89 commented Apr 11, 2018 •
edited
Loading

Don't you think we should start by writing tests for the classes? I think that a substantial refactoring is quite likely to introduce a lot of small errors that we may not see without tests.

@michaelhglass
Copy link
Member Author

At this point, I only addressed style issues that should (in the best case) not change the code significantly and should be doable via code-review. At least my 2cc. The one mistake caught by Felix was in fact a dumb mistake by me, but spotting a line changing from w1 != w0 to w1 == w0 is what we have code review for, right?

@FedorSmirnov89
Copy link
Member

I just mean that in the long run, we have to both write tests and address the issues anyway. And having tests makes refactoring very comfortable

michaelhglass added a commit that referenced this issue Apr 20, 2018
@michaelhglass
Patch/#35 codacy issues (#38)
5a72265 
* codacy issues fixed for org.opt4j.viewer.*

* codacy issues fixed for org.opt4j.tutorial.* except prettify.js

* codacy issues fixed for org.opt4j.satdecoding.*

* codacy issues fixed for org.opt4j.satdecoding.*

* codaxy issues fixed for org.opt4j.optimizers.* except fronts in
hypervolume

* codaxy issues fixed for org.opt4j.optimizers.*

* codacy issued fixed for org.opt4j.operators.*

* codacy issue fix

* codacy issues fixed in part for org.opt4j.core.*

* PMD CompareObjectsWithEquals requires more careful consideration;
reverted respective occurrences

* codacy issues fixed for org.opt4j.benchmarks.*

* Ignore ptolemy-plot sources, *.js, and *.py source files in codacy

* giving different syntax a try

* fixes according to pull-request review by felixreimann

* addressed review by felixreimann
@michaelhglass
Copy link
Member Author

Current issues solved. Further discussion in #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelhglass michaelhglass

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelhglass @FedorSmirnov89