Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'getenv' calls with 'get_symbol' calls instead #21

Closed
Fish-Git opened this issue Nov 26, 2017 · 2 comments
Closed

Replace 'getenv' calls with 'get_symbol' calls instead #21

Fish-Git opened this issue Nov 26, 2017 · 2 comments
Assignees
@Fish-Git
Labels
Enhancement This issue does not describe a problem but rather describes a suggested change or improvement.

Comments

@Fish-Git
Copy link
Member

Fish-Git commented Nov 26, 2017 •
edited

Replace getenv calls with get_symbol instead, to make it easier to override an existing or non-existing environment variable setting (such as HERCULES_IFC for example).

Our existing get_symbol functionality already contains logic to call getenv if the specified symbol is not defined to Hercules's existing symbol pool, so the end result should be completely transparent to the user and would provide much improved functionality not to mention easier debugging.
@Fish-Git Fish-Git added the Enhancement This issue does not describe a problem but rather describes a suggested change or improvement. label Dec 5, 2017
@Fish-Git Fish-Git self-assigned this Jan 20, 2019
@Fish-Git Fish-Git added the IN PROGRESS... I'm working on it! (Or someone else is!) label Jan 20, 2019
Fish-Git added a commit that referenced this issue Jan 20, 2019
@Fish-Git
Replace 'getenv' calls with 'get_symbol' calls instead:
38d1785 
Closes GitHub Issue #21.
@Fish-Git Fish-Git removed the IN PROGRESS... I'm working on it! (Or someone else is!) label Jan 20, 2019
@Fish-Git
Copy link
Member Author

Closed by 38d1785.

@Fish-Git
Copy link
Member Author

Closed by 38d1785.

... AND by commit 5788468!!

@Fish-Git Fish-Git mentioned this issue Jan 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fish-Git Fish-Git

Labels
Enhancement This issue does not describe a problem but rather describes a suggested change or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fish-Git