Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version not reported (and no help given) if bad/no arguments given #540

Closed
Fish-Git opened this issue Jan 24, 2023 · 2 comments
Closed

Version not reported (and no help given) if bad/no arguments given #540

Fish-Git opened this issue Jan 24, 2023 · 2 comments
Labels
BUG The issue describes likely incorrect product functionality that likely needs corrected.

Comments

@Fish-Git
Copy link
Member

Hercules should really support either:

  • a) always reporting its version even when no (or invalid) arguments are given, or
  • b) a new --version argument to report its current version then exit.

Additionally, it should also report all of the valid arguments that it supports too, just like virtually all command line programs out there do! (Hercules currently doesn't even do that! Sheesh!)

 
All of the Hercules utilities, for example, always report right away what version they are even when no arguments are given:

C:\hercules> dasdser
HHC02499I Hercules utility dasdser - DASD serial number utility - version 4.6.0.10880-SDL-DEV-g468b76cd
HHC01414I (C) Copyright 1999-2023 by Roger Bowler, Jan Jaeger, and others
HHC01417I ** The SoftDevLabs version of Hercules **
HHC01415I Build date: Jan 24 2023 at 10:49:22
HHC03100I Usage: dasdser  image  [serial]
HHC03100I   image    base CKD dasd image file
HHC03100I   serial   serial number to set. If not given then the
HHC03100I            existing serial number is simply displayed.

But Hercules itself however, unfortunately does not:

C:\hercules> hercules
HHC00100I Thread id 00002380, prio 5, name 'impl_thread' started
HHC00100I Thread id 000011e4, prio 4, name 'logger_thread' started
HHC02342S Configuration file 'hercules.cnf' not found: No such file or directory
HHC00007I Previous message from function 'process_args' at impl.c(1900)
HHC02343S Terminating due to 1 argument errors
HHC00007I Previous message from function 'impl' at impl.c(1146)
HHC01420I Begin Hercules shutdown
HHC01423I Calling termination routines
HHC01424I All termination routines complete
HHC01425I Hercules shutdown complete
HHC01412I Hercules terminated

If you specify valid arguments however, it will startup normally in panel mode and the version information is shown in the panel:

image

(in the above, I specified hercules -f none to indicate no config file.)

But doing so is inconvenient just to determine Hercules's version, especially since users might not be familiar with that particular feature/option of Hercules or even be familiar with any of Hercules's various command line arguments!

This needs to be fixed.

@Fish-Git Fish-Git added the BUG The issue describes likely incorrect product functionality that likely needs corrected. label Jan 24, 2023
Fish-Git added a commit that referenced this issue Jan 24, 2023
@Fish-Git
Copy link
Member Author

Well THAT was easy!

Fixed by commit f7373b7.

Closing.

@wrljet
Copy link
Member

wrljet commented Jan 24, 2023

I've been meaning to complain about that for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG The issue describes likely incorrect product functionality that likely needs corrected.
Projects
None yet
Development

No branches or pull requests

2 participants