SDWebImageDownloaderOperation isFinished - race condition

[ganeshAir]

New Issue Checklist

• I have read and understood the CONTRIBUTING guide
• I have read the Documentation
• I have searched for a similar issue in the project and found none

Issue Info

Info	Value
Platform Name	e.g. ios / macos / tvos / watchos
Platform Version	e.g. 12.0 / 10.14.0 / 12.0 / 5.0
SDWebImage Version	e.g. 5.0.0 / 4.4.0
Integration Method	e.g. carthage / cocoapods / manually
Xcode Version	e.g. Xcode 11 / Xcode 10
Repro rate	e.g. all the time (100%) / sometimes x% / only once
Repro with our demo prj	e.g. does it happen with our demo project?
Demo project link	e.g. link to a demo project that highlights the issue

Issue Description and Steps

Please fill in the detailed description of the issue (full output of any stack trace, compiler error, ...) and the steps to reproduce the issue.

[ganeshAir]

Need to synchronize the getter and setter.

[kinarobin]

@ganeshAir How about using the latest version 5.11.1 ？

[ganeshAir]

Issue is happening in the latest version as well.

[ganeshAir]

[kinarobin]

@ganeshAir Reproduce demo, thanks.

[ganeshAir]

There is no straight forward scenario to share a demo. But one solution I can suggest is to reproduce is enable thread sanitizer and run in Xcode. And also clearly visible the property is nonatomic. If you declare it as atomic this issue might resolve. Thanks & Regards, Ganesh TR

…

On Tue, Sep 28, 2021 at 6:11 PM Kinarobin ***@***.***> wrote: @ganeshAir <https://github.com/ganeshAir> Reproduce demo, thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3275 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AV2KAS6WB5H7OU66DJQB64LUEGZWHANCNFSM5E426QBA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Disclaimer: This email and any files transmitted with it are confidential and may be privileged. It is intended solely for the above addressee. If you have received it in error please delete it and notify the sender. The unauthorized use, disclosure, copying, alteration or dissemination of any information in this e-mail is strictly forbidden. AirAsia and its affiliates accepts no liability whatsoever that may arise from or in connection with this e-mail and/or its contents. AirAsia Group promotes all aspects of Proper Corporate Governance through Policies and Procedures. We inculcate a Zero-Tolerance Policy for any act of Bribery and/or Corruption.

--

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

[iDevPro]

Hello, latest version of SD (main branch),

SDWebImagePrefetcher.shared.prefetchURLs -> RaceCodition
Example.prefetchUrls on image call SDWebImagePrefetcher.shared.prefetchURLs

[dreampiggy]

Seems this SDAsyncBlockOperation need a synchronized solution for that isFinished property, will fix in 5.15.1

[dreampiggy]

In this example, the issue happends because SDAsyncBlockOperation is called with complete even before the actualstart method (which is the entry for NSOperation)

This may a case when ImageManager has already cache the image in memory cache, so it callback in sync but not async, cause logic error