CFBundleVersion fix for 4.0.0 release #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CFBundleVersion if set as in Info.plist files. In WebImage/Info.plist is set explicitly to 400.
|
Related to #1780 |
3 tasks
bpoplauschi
added a commit
that referenced
this pull request
Feb 18, 2017
…tVersionString - same as for AFNetworking)
|
Thanks @ivan-konov. I made a small change to your code, set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposed sample fix for the problem with submitting builds to iTunes if CFBundleVersion has no value. The problem was that there was not value set for "Current Project Version" in the project settings an the Info.plist for the library targets had a value of $(CURRENT_PROJECT_VERSION).
I have used sample values just to illustrate the solution. Here is a useful read on CFBundleVersion - http://hboon.com/difference-between-cfbundleversion-and-cfbundleshortversionstring/
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / reffers to the following issues: ...
Pull Request Description
...