Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow App Store submit rule, upgrade the minimum Xcode version to Xcode 10.0 #2780

Merged
merged 3 commits into from Jul 3, 2019

Conversation

dreampiggy
Copy link
Contributor

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: #2372 #2766

Pull Request Description

See the similar PR #2372

Xcode 11 is now available via WWDC 2019. And Xcode 9 is 2 years ago.

According to App Store Submit Rule. All the new or upgrade version for Apps MUST link iOS 12 SDK & Xcode 10. So it's time to drop Xcode 9.0 support. See: https://developer.apple.com/news/?id=03202019a

Starting March 27, 2019, all new apps and app updates for iPhone or iPad, including universal apps, must be built with the iOS 12.1 SDK or later and support iPhone XS Max or the 12.9-inch iPad Pro (3rd generation). Screenshots for these devices will also be required. All new apps and app updates for Apple Watch will need to be built with the watchOS 5.1 SDK or later and support Apple Watch Series 4.

Beside this, Xcode 10 bring the support like Using ARC Objective-C object in C struct filed, New Build System, Xcode 10 File List, some of them can be helpful for us. Upgrating the developer toolchain version is easier than the minimum deployment target version as well.

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #2780 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2780      +/-   ##
==========================================
+ Coverage   83.57%   83.86%   +0.28%     
==========================================
  Files          57       57              
  Lines        6285     6285              
==========================================
+ Hits         5253     5271      +18     
+ Misses       1032     1014      -18
Flag Coverage Δ
#ios 84.78% <ø> (+0.17%) ⬆️
#macos 82.81% <ø> (+0.16%) ⬆️
Impacted Files Coverage Δ
SDWebImage/SDWebImageIndicator.m 74.21% <ø> (ø) ⬆️
SDWebImage/SDWebImageManager.m 87.4% <0%> (-0.77%) ⬇️
SDWebImage/SDAnimatedImageView.m 79.85% <0%> (+2.45%) ⬆️
SDWebImage/SDWebImageDownloaderOperation.m 91.3% <0%> (+3.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 049feda...5c22cc7. Read the comment docs.

@dreampiggy dreampiggy merged commit 5df7062 into SDWebImage:master Jul 3, 2019
@dreampiggy dreampiggy deleted the project_upgrade_xcode_10 branch July 3, 2019 08:46
@dreampiggy dreampiggy added this to the 5.1.0 milestone Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants