Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix the issue that "There may be no complete callback when download the picture of the local path" #2916

Conversation

dreampiggy
Copy link
Contributor

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: #2910

Pull Request Description

4.x branch.

@dreampiggy dreampiggy added the fix label Dec 26, 2019
@dreampiggy dreampiggy added this to the 4.4.8 milestone Dec 26, 2019
@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #2916 into 4.x will decrease coverage by 4.74%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              4.x    #2916      +/-   ##
==========================================
- Coverage   75.15%   70.41%   -4.75%     
==========================================
  Files          37       29       -8     
  Lines        4074     3231     -843     
==========================================
- Hits         3062     2275     -787     
+ Misses       1012      956      -56
Impacted Files Coverage Δ
SDWebImage/SDWebImageDownloader.m 77.9% <86.66%> (+0.61%) ⬆️
SDWebImage/SDWebImageDownloaderOperation.m 87.08% <0%> (-2.99%) ⬇️
SDWebImage/SDImageCache.m 65.09% <0%> (-0.42%) ⬇️
Tests/Tests/SDWebImageTestDecoder.m
Tests/Tests/SDWebImageDecoderTests.m
Tests/Tests/SDTestCase.m
Tests/Tests/SDCategoriesTests.m
Tests/Tests/SDWebImagePrefetcherTests.m
Tests/Tests/SDWebImageManagerTests.m
Tests/Tests/SDImageCacheTests.m
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea9a76...8bc04d6. Read the comment docs.

@dreampiggy dreampiggy merged commit 0cd36c6 into SDWebImage:4.x Dec 26, 2019
@dreampiggy dreampiggy deleted the fix_local_download_operation_finished_without_callback branch December 26, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant