Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that when first play animated image and use maxBufferSize to 0, the calculation does not works (The CGImage is nil) #2982

Conversation

dreampiggy
Copy link
Contributor

@dreampiggy dreampiggy commented Apr 10, 2020

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...

Pull Request Description

This does not work as expected:

image

…he calculation does not works (The CGImage is nil)
@dreampiggy dreampiggy merged commit dddf4a8 into SDWebImage:master Apr 11, 2020
@dreampiggy dreampiggy deleted the bugfix_animated_image_buffer_calculation branch April 11, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants