Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Typos throughout project #3026

Merged
merged 2 commits into from Jun 1, 2020

Conversation

jstart
Copy link
Contributor

@jstart jstart commented Jun 1, 2020

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

Pull Request Description

Used the new Xcode spellcheck tool to go through each file to look for common misspellings and gramar errors. Mostly just in comments, but found one misspelled function name.

Let me know if there is anything else I need to do to merge this. Thank you!

Copy link
Contributor

@dreampiggy dreampiggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this typo fix. Most of contributors are not native English spearkers. 😅

@dreampiggy dreampiggy merged commit c4acfe5 into SDWebImage:master Jun 1, 2020
@dreampiggy dreampiggy added this to the 5.8.1 milestone Jun 1, 2020
@bpoplauschi
Copy link
Member

@jstart Thanks a lot for showing interest and contributing to SDWebImage! We would like to invite you to become a maintainer – no pressure to accept! You can pitch in with what seems comfortable: comment on open issues/PRs, triage, improve documentation, write your own PRs. Let me know if you are interested.

@jstart jstart deleted the jstart/typo-cleanup branch June 1, 2020 16:48
@jstart
Copy link
Contributor Author

jstart commented Jun 2, 2020

@bpoplauschi I'd be happy to! Not sure how much time I'll be able to devote, but I can do my best. We use SDWebImage @postmates so we rely on it pretty heavily in production 👍

@bpoplauschi
Copy link
Member

Great @jstart, I just sent you an invite to our organization. I know what you mean about finding time, I'm sure you'll do your best, as we all do. Every contribution counts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants