Add an option to scale down large images on iOS #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option is SDWebImageScaleDownLargeImage
Option is SDWebImageScaleDownLargeImage
Conflicts: SDWebImage/SDWebImageDecoder.m
Code copy from the Apple Sample code "Large Image Downsizing" https://developer.apple.com/Library/ios/samplecode/LargeImageDownsizing/Introduction/Intro.html#//apple_ref/doc/uid/DTS40011173-Intro-DontLinkElementID_2
bpoplauschi
added a commit
that referenced
this pull request
Oct 6, 2016
Add an option to scale down large images on iOS
bpoplauschi
added a commit
that referenced
this pull request
Oct 6, 2016
This was referenced Oct 6, 2016
Closed
intmain
added a commit
to intmain/SDWebImage
that referenced
this pull request
Jan 4, 2017
* 'master' of https://github.com/rs/SDWebImage: (196 commits) Word corrections Fixed SDWebImage#1693 Same URLs didn't cancel download Updated links for documentation 1st draft for the 4.0 Migration Guide. Described the changes per component. Now we need to add examples for the most common cases. Marked the `SDWebImageManager` `initWithCache:downloader:` as designated initializer. Updated diagrams according to current 4.0.0 status Updated CHANGELOG (date) Bumped version to 4.0.0-beta2 Updated CHANGELOG Fixed SDWebImage#1668 CGContextDrawImage: invalid context 0x0 Updated CHANGELOG Added tests for the scale down decoding + test image and updated a bit the other decoder tests Test xcodeproj updated to Xcode 8 Fixed a bug introduced by 00bf467 No more carthage, d6fa29c removed it, now also remove installing it via brew Update for SDWebImage#787 Add an option to scale down large images on iOS - code cleanup Changelog update Updated the README backwards compatibility section and linked the 4.0 Migration Guide Added a draft for the Migration Guide document. Added the Docs folder to the Xcode workspace ... # Conflicts: # SDWebImage.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difference with the previous PR #769:
Comment from the previous PR:
Let me know what you think?
PS: I create a new pull request because I think my previous one closed can't be updated