Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports to use this framework backward deployable on iOS 12/macOS 10.14- #15

Merged
merged 5 commits into from Jan 9, 2020

Conversation

dreampiggy
Copy link
Contributor

@dreampiggy dreampiggy commented Jan 9, 2020

This close #14

Sample code:

func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
    // Override point for customization after application launch.
    if #available(iOS 13, *) {
        // iOS 13 use UIWindowScene
        SDImageLoadersManager.shared.addLoader(SDImageLinkLoader.shared)
    } else {
        window = UIWindow(frame: UIScreen.main.bounds)
        window?.rootViewController = ViewController()
        window?.makeKeyAndVisible()
    }
    return true
}

Before :

image

After:

image

@dreampiggy dreampiggy changed the title Project backward deployment Supports to use this framework backward deployable on iOS 12/macOS 10.14- Jan 9, 2020
@dreampiggy dreampiggy added the project Project Setting related label Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   60.08%   60.08%           
=======================================
  Files           2        2           
  Lines         223      223           
=======================================
  Hits          134      134           
  Misses         89       89
Flag Coverage Δ
#iOS 60.08% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a97d3e...dde632c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project Project Setting related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'dyld: Library not loaded' error in iOS versions pre-iOS13
1 participant