Using try-catch for CoreSVG vector image before rendering on screen, protect some crashes for user #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
changed the title
dreampiggy
added
crash
CoreSVG
dreampiggy
force-pushed
the
bugfix/catch_vector_svg_before_rendering
branch
from
2cb4fca
to
330fe84
Compare
…protect some crash for user However, this can only solve some of crashes, some of crashes like Danger Pointer are un-catchable
dreampiggy
force-pushed
the
bugfix/catch_vector_svg_before_rendering
branch
from
330fe84
to
7ff561a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This close #43
This close #41
However, this can only solve some of crashes, some of crashes like Danger Pointer are un-catchable