Fix iOS 13 compatibility && WebImage/AnimatedImage using @State to publish changes #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
changed the title
dreampiggy
force-pushed
the
fix_backport_ios13
branch
2 times, most recently
from
a9d546a
to
3f31457
Compare
Revert back the onPlatformAppear to fix iOS 14+ behavior Use backport for all OSs
|
The fix behavior for You can change the Video: |
Using the `StateObject` to check and refresh to the latest status, using `currentURL` and `currentAnimatedImage` to check lazily
dreampiggy
force-pushed
the
fix_backport_ios13
branch
from
3f31457
to
d281bde
Compare
Move the reset logic into helper function setupManager
This was referenced Sep 21, 2022
|
I think the version should bump to v2.2, not v2.1.1 patch, because it seems there are API changes and it's more than a simple bugfix. |
dreampiggy
force-pushed
the
fix_backport_ios13
branch
from
de1d424
to
5a5690e
Compare
|
All tests passed now. |
dreampiggy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ImageManagerAPI changes. Theinitmethod has no args, useload(url:options:context:)insteadThis PR close #230 close #229 close #228
As for now, Swift still can not use different stored property on different availability check OS Host. This is runtime limit. Previous #227 will cause a Swift runtime crash when demangling symbols from iOS 13+
So, I just remove the
SwiftUI.StateObjectreferences and use Backport + PlatformAppear hack (BecauseSwiftUI.List'sonAppeardoes not works as expected when using nonSwiftUI.StateObject)v3.0.0 will remove iOS 13 support.