Fix the leak of WebImage with animation and NavigationLink. #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is because of @State which may cause reference cycle
dreampiggy
commented
Feb 22, 2021
| if let animatedImage = image as? SDAnimatedImageProvider { | ||
| if let imagePlayer = SDAnimatedImagePlayer(provider: animatedImage) { | ||
| imagePlayer.animationFrameHandler = { (_, frame) in | ||
| self.currentFrame = frame |
There was a problem hiding this comment.
Here.
From Swift, the struct will not cause retain cycle. However, SwiftUI @State will keep an StorageLocation with an global mapping, which bind each View struct with the @State reference type. (Yes, each View struct will keep an reference)
So, if we write here, the retain cycle is:
View StorageLocation -> SDAnimatedImagePlayer -> animationFrameHandler -> View StorageLocation
There was a problem hiding this comment.
By break off to use ImageManager a pure ObservableObject, this retain cycle can be avoided.
This was referenced Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leak is because of @State which may cause reference cycle.
See result: