Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit testing - step 2 #151

Open
8 tasks
iricigor opened this issue May 16, 2020 · 0 comments
Open
8 tasks

unit testing - step 2 #151

iricigor opened this issue May 16, 2020 · 0 comments
Labels
exceptions-handling good first issue Good for newcomers testing Testing needs to be implemented or fixed
Milestone
v0.6

Comments

@iricigor
Copy link
Contributor

iricigor commented May 16, 2020 •
edited
Loading

This is continuing from issue #135 and PR #149

Next tasks in unit testing:

  • Add negative tests where possible
  • Add mock for GetToken in IDCheck tests
  • fix other TODO: issues
  • merge similar tests into Theory
  • align test cases according to AAA approach (arrange-act-assert) (three lines of code)
  • add more descriptive test names (see comment in PR adding unit testing #149 )

Pipeline related tasks

  • Confirm pipeline is integrated as PR validation
  • re-check code coverage in pipeline
@iricigor iricigor added the testing Testing needs to be implemented or fixed label May 16, 2020
@iricigor iricigor added this to the later milestone May 16, 2020
@iricigor iricigor added the good first issue Good for newcomers label May 17, 2020
@iricigor iricigor mentioned this issue Jul 8, 2020
Merged
@iricigor iricigor modified the milestones: later, v0.6 Oct 8, 2020
@MangyCoyote MangyCoyote removed their assignment Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exceptions-handling good first issue Good for newcomers testing Testing needs to be implemented or fixed
Projects
None yet
Milestone
v0.6
Development

No branches or pull requests
2 participants
@iricigor @MangyCoyote