Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code smell removal: #113

Merged
merged 6 commits into from
Jun 19, 2023
Merged

code smell removal: #113

merged 6 commits into from
Jun 19, 2023

Conversation

MozartAmadeus
Copy link
Contributor

  • removal of empty constructor

MozartAmadeus and others added 6 commits June 19, 2023 12:56
@MozartAmadeus
code smell removal:
7aa102a 
- removal of empty constructor
@MozartAmadeus
Merge branch 'main' into test/gameState
773c537
@MozartAmadeus
code smell removal:
60c60cc 
- removal of flavor_txt from cards to only have 7 param in constructor
@MozartAmadeus
code smell removal:
a6461f5 
- removal of unused flavor_txt
@MozartAmadeus
Merge remote-tracking branch 'origin/test/gameState' into test/gameState
6bbadaa
@MozartAmadeus
code smell removal:
38fadb9 
- removal of unused flavor_txt in tests
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Shaitan7 Shaitan7 merged commit 515f833 into main Jun 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaitan7 Shaitan7 Shaitan7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MozartAmadeus @Shaitan7