Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic endpoint #14

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Basic endpoint #14

merged 2 commits into from
Mar 10, 2022

Conversation

f-fromont
Copy link
Contributor

@f-fromont f-fromont commented Mar 10, 2022

Description

This PR, contains the code that added an extremely basic endpoint /api/basic/hello/{name} which was put in place for allowing backend members to test that their repo setup correctly and that the server can run.

An h2 ( in memory ) database needed to be added to the pom.xml & application.properties since there was no dataSource for the spring framework, and the specific framework used needs to be pointed towards a Database driver before the server can run, this was used as a temporary fix, but a new issue has been created for us to discuss at a meeting if we would like to change the database, this issue is #13

To call the endpoint use the following:
http://localhost:8080/api/basic/hello/{your-name}
Fixes #12

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Screenshots

Provide screenshots of what has been implemented. Leave blank if not applicable

Checklist

(Leave blank if not applicable)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

+ Needed to add h2 database as a possible temporary measure, since Spring required a database source before starting the server
@f-fromont f-fromont added Priority: Medium Status: Review Needed The implementation has finished and someone has been approached for review. Type: Feature The issue is about a new feature being introduced to the project. labels Mar 10, 2022
Copy link
Contributor

@ejstuart ejstuart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ejstuart
Copy link
Contributor

Although don't forget to squash your commits

@f-fromont f-fromont merged commit cdb3671 into SE701-T1:main Mar 10, 2022
@f-fromont f-fromont deleted the basic-endpoint branch March 10, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Status: Review Needed The implementation has finished and someone has been approached for review. Type: Feature The issue is about a new feature being introduced to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a basic endpoint for testing server
3 participants