Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #12

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Add CODEOWNERS #12

merged 2 commits into from
Mar 14, 2022

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Mar 13, 2022

Description

A CODEOWNERS file is used by GitHub to define who is automatically requested to review pull requests with changes to code they are responsible for.

This CODEOWNERS file added to the SE701-T5/Backend repository defines the @SE701-T5/backend team as responsible by default for all changes with exception to:

  • README.md
  • LICENSE
  • .github/*

which all the @SE701-T5/team5 is responsible for as these are documents and changes to these are team-related.

The CODEOWNERS file is located in the .github/ directory.

Related Issue

Solves #10

Type of change

  • Documentation

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Has a self- and/or peer-review of the code been performed?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines document.

@R055A R055A added the documentation Improvements or additions to documentation label Mar 13, 2022
@R055A R055A added this to the Assignment 1 milestone Mar 13, 2022
@R055A R055A requested a review from a team March 13, 2022 21:59
@R055A R055A self-assigned this Mar 13, 2022
@R055A R055A added this to In progress in Team 5 - Assignment 1 - Backend via automation Mar 13, 2022
@R055A R055A linked an issue Mar 13, 2022 that may be closed by this pull request
@R055A R055A moved this from In progress to Review in progress in Team 5 - Assignment 1 - Backend Mar 13, 2022
@R055A R055A moved this from Review in progress to In progress in Team 5 - Assignment 1 - Backend Mar 13, 2022
Copy link

@emettreio emettreio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@R055A
Copy link
Contributor Author

R055A commented Mar 13, 2022

Makes sense to me!

Thank you @ThatRandomCoderNZ

You have to accept the PR in a review. Refer to the button on the top right of the page.

Team 5 - Assignment 1 - Backend automation moved this from In progress to Reviewer approved Mar 13, 2022
@AlexMiao7 AlexMiao7 self-requested a review March 13, 2022 23:02
@R055A R055A requested review from hiin3d55 and qzho236 March 14, 2022 00:09
Copy link
Contributor

@hiin3d55 hiin3d55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@R055A R055A merged commit f674115 into SE701-T5:main Mar 14, 2022
Team 5 - Assignment 1 - Backend automation moved this from Reviewer approved to Done Mar 14, 2022
@R055A R055A deleted the code-owners branch March 14, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add CODEOWNERS
5 participants