Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #3

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Add CONTRIBUTING.md #3

merged 5 commits into from
Mar 14, 2022

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Mar 10, 2022

For issue: #2

Add the contribution guideline as a markdown file named CONTRIBUTING.md in /.github directory for GitHub to link to (refer to the bottom right of Issues when creating them).

This issue and subsequent Pull Request are intended for all the team to review and approve the contribution guidelines before @R055A merges them; like signing a contract.

@R055A R055A added the documentation Improvements or additions to documentation label Mar 10, 2022
@R055A R055A added this to the Assignment 1 milestone Mar 10, 2022
@R055A R055A added this to Review in progress in Team 5 - Assignment 1 - Backend via automation Mar 10, 2022
@R055A R055A self-assigned this Mar 10, 2022
@R055A R055A moved this from Review in progress to In progress in Team 5 - Assignment 1 - Backend Mar 10, 2022
@R055A R055A removed their assignment Mar 10, 2022
@R055A R055A linked an issue Mar 11, 2022 that may be closed by this pull request
@R055A R055A requested a review from kimslor March 11, 2022 00:20
@AlexMiao7 AlexMiao7 self-requested a review March 11, 2022 00:46
Team 5 - Assignment 1 - Backend automation moved this from In progress to Reviewer approved Mar 11, 2022
AlexMiao7
AlexMiao7 previously approved these changes Mar 11, 2022
Copy link
Contributor

@AlexMiao7 AlexMiao7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

kimslor
kimslor previously approved these changes Mar 11, 2022
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@R055A R055A dismissed stale reviews from kimslor and AlexMiao7 via 2458d55 March 11, 2022 02:14
Team 5 - Assignment 1 - Backend automation moved this from Reviewer approved to In progress Mar 11, 2022
@R055A R055A requested review from kimslor and AlexMiao7 March 11, 2022 02:15
@hpar461 hpar461 self-requested a review March 11, 2022 02:42
Team 5 - Assignment 1 - Backend automation moved this from In progress to Reviewer approved Mar 11, 2022
kimslor
kimslor previously approved these changes Mar 11, 2022
Team 5 - Assignment 1 - Backend automation moved this from Reviewer approved to In progress Mar 11, 2022
Team 5 - Assignment 1 - Backend automation moved this from In progress to Reviewer approved Mar 11, 2022
@R055A R055A assigned R055A and unassigned christopher-alba Mar 12, 2022
AlexMiao7
AlexMiao7 previously approved these changes Mar 12, 2022
kimslor
kimslor previously approved these changes Mar 12, 2022
@R055A R055A requested review from hiin3d55 and qzho236 March 12, 2022 15:33
@R055A R055A dismissed stale reviews from kimslor, AlexMiao7, and christopher-alba via 440fb6e March 13, 2022 22:17
Team 5 - Assignment 1 - Backend automation moved this from Reviewer approved to In progress Mar 13, 2022
Team 5 - Assignment 1 - Backend automation moved this from In progress to Reviewer approved Mar 13, 2022
Copy link
Contributor

@hiin3d55 hiin3d55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@R055A R055A merged commit e9fdbfc into SE701-T5:main Mar 14, 2022
Team 5 - Assignment 1 - Backend automation moved this from Reviewer approved to Done Mar 14, 2022
@R055A R055A deleted the contribution-guidelines branch March 14, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING.md
8 participants