Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pull Request CI Workflow #44

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Fix Pull Request CI Workflow #44

merged 4 commits into from
Mar 17, 2022

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Mar 17, 2022

Description

Currently the automated continuous integration workflow is not accessing secrets for pull requests when they are opened. This causes the CI tests to fail as the environment variables stored as secrets are required for successfully running and passing the automated tests. This can be misleading if the changes in the pull requests are not failing the same CI workflow tests in the development branches.

This pull request is the second attempt in aiming to try and fix this issue.

This fix is resourced from:
Using Environment Protection Rules to Secure Secrets When Building External Forks with pull_request_target by Petr Švihlík.

Related Issue

Solves #42

Type of change

  • Bug fix

How Has This Been Tested?

It is not possible to test given the resources available. To test this requires merging it to the master and then re-running the CI worjflows for all other existing pull requests.

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Does the code build without new warnings?
  • Has a self- and/or peer-review of the code been performed?
  • Does all new and existing automated testing pass?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

@R055A R055A added the bug Something isn't working label Mar 17, 2022
@R055A R055A added this to the Assignment 1 milestone Mar 17, 2022
@R055A R055A requested a review from a team as a code owner March 17, 2022 00:52
@R055A R055A added this to In progress in Team 5 - Assignment 1 - Backend via automation Mar 17, 2022
@R055A R055A self-assigned this Mar 17, 2022
@R055A R055A linked an issue Mar 17, 2022 that may be closed by this pull request
Fix Pull Request CI Workflow #42
Closed
hiin3d55
hiin3d55 approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@hiin3d55 hiin3d55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Team 5 - Assignment 1 - Backend automation moved this from In progress to Reviewer approved Mar 17, 2022
@R055A R055A merged commit 2942417 into SE701-T5:main Mar 17, 2022
Team 5 - Assignment 1 - Backend automation moved this from Reviewer approved to Done Mar 17, 2022
@R055A R055A deleted the fix-ci-workflow branch March 17, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiin3d55 hiin3d55 hiin3d55 approved these changes

Assignees

@R055A R055A

Labels
bug Something isn't working
Projects
No open projects
Team 5 - Assignment 1 - Backend
Done
Milestone
Assignment 1
Development

Successfully merging this pull request may close these issues.

Fix Pull Request CI Workflow
2 participants
@R055A @hiin3d55