Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement random name generation for forum user. #56

Merged
merged 10 commits into from
Mar 19, 2022
Merged

Implement random name generation for forum user. #56

merged 10 commits into from
Mar 19, 2022

Conversation

kimslor
Copy link
Contributor

@kimslor kimslor commented Mar 18, 2022 •
edited
Loading

Description

Removing requirement for displayName field to be required for user creation.
This display will be randomly generated for a user when their account is created.

Related Issue

Solves #38

Type of change

  • New feature (enhancement)

How Has This Been Tested?

  • Automated testing

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Does the code build without new warnings?
  • Has testing been performed that proves changes are effective and work?
  • Has a self- and/or peer-review of the code been performed?
  • Have dependent changes been merged and published in downstream modules?
  • Does all new and existing automated testing pass?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.

@kimslor kimslor added the enhancement New feature or request label Mar 18, 2022
@kimslor kimslor added this to the Assignment 1 milestone Mar 18, 2022
@kimslor kimslor requested a review from a team as a code owner March 18, 2022 07:20
@kimslor kimslor added this to In progress in Team 5 - Assignment 1 - Backend via automation Mar 18, 2022
@kimslor kimslor moved this from In progress to Review in progress in Team 5 - Assignment 1 - Backend Mar 18, 2022
@R055A R055A self-requested a review March 18, 2022 08:27
@R055A R055A moved this from Review in progress to In progress in Team 5 - Assignment 1 - Backend Mar 18, 2022
@R055A R055A linked an issue Mar 18, 2022 that may be closed by this pull request
Randomly generate forum user's name #38
Closed
R055A
R055A suggested changes Mar 18, 2022
View reviewed changes
controllers/user.server.controller.js Outdated Show resolved Hide resolved
test/user.test.js Show resolved Hide resolved
@kimslor kimslor requested review from a team and R055A March 18, 2022 22:49
R055A
R055A suggested changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@R055A R055A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small changes

config/db_schemas/user.schema.js Outdated Show resolved Hide resolved
test/schemas.test.js Outdated Show resolved Hide resolved
@R055A R055A self-requested a review March 19, 2022 03:46
Team 5 - Assignment 1 - Backend automation moved this from In progress to Reviewer approved Mar 19, 2022
@R055A R055A merged commit 11cd32a into SE701-T5:main Mar 19, 2022
Team 5 - Assignment 1 - Backend automation moved this from Reviewer approved to Done Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R055A R055A R055A approved these changes

Assignees

@R055A R055A

Labels
enhancement New feature or request
Projects
No open projects
Team 5 - Assignment 1 - Backend
Done
Milestone
Assignment 1
Development

Successfully merging this pull request may close these issues.

Randomly generate forum user's name
2 participants
@kimslor @R055A