Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with heroku deployment. #66

Merged
merged 3 commits into from
Mar 19, 2022
Merged

Fixed bug with heroku deployment. #66

merged 3 commits into from
Mar 19, 2022

Conversation

kimslor
Copy link
Contributor

@kimslor kimslor commented Mar 19, 2022 •
edited by R055A
Loading

Description

Changed the start script to use node instead of nodemon.
Added dev option to use nodemon.

A mistake was made reviewing this pull request. An explanation with the correction can be found here #67

Related Issue

Solves #65

Type of change

  • Bug fix

How Has This Been Tested?

  • Automated testing

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Does the code build without new warnings?
  • Has testing been performed that proves changes are effective and work?
  • Has a self- and/or peer-review of the code been performed?
  • Have dependent changes been merged and published in downstream modules?
  • Does all new and existing automated testing pass?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.

@kimslor kimslor added the bug Something isn't working label Mar 19, 2022
@kimslor kimslor added this to the Assignment 1 milestone Mar 19, 2022
@kimslor kimslor requested a review from a team as a code owner March 19, 2022 06:33
@kimslor kimslor added this to In progress in Team 5 - Assignment 1 - Backend via automation Mar 19, 2022
@kimslor kimslor changed the title Changed start script from nodemon to node. Fixed bug with heroku deployment. Mar 19, 2022
@R055A R055A linked an issue Mar 19, 2022 that may be closed by this pull request
Fix heroku deployment bug. #65
Closed
R055A
R055A suggested changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@R055A R055A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you. There is just one suggestion to consider, please.

package.json Outdated Show resolved Hide resolved
R055A
R055A suggested changes Mar 19, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
christopher-alba
christopher-alba approved these changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@christopher-alba christopher-alba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

R055A
R055A approved these changes Mar 19, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
Team 5 - Assignment 1 - Backend automation moved this from In progress to Reviewer approved Mar 19, 2022
@R055A R055A merged commit c0e0fd5 into SE701-T5:main Mar 19, 2022
Team 5 - Assignment 1 - Backend automation moved this from Reviewer approved to Done Mar 19, 2022
R055A added a commit that referenced this pull request Mar 19, 2022
@R055A
Revert "Fixed bug with heroku deployment. (#66)"
305160f 
This reverts commit c0e0fd5.
@R055A R055A mentioned this pull request Mar 19, 2022
Merged
R055A added a commit that referenced this pull request Mar 19, 2022
@R055A
Fix package.json for Heroku Deployment (#67)
00e55d9 
* Revert "Fixed bug with heroku deployment. (#66)"

This reverts commit c0e0fd5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R055A R055A R055A approved these changes

@christopher-alba christopher-alba christopher-alba approved these changes

Assignees

@R055A R055A

Labels
bug Something isn't working
Projects
No open projects
Team 5 - Assignment 1 - Backend
Done
Milestone
Assignment 1
Development

Successfully merging this pull request may close these issues.

Fix heroku deployment bug.
3 participants
@kimslor @R055A @christopher-alba