Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update project files #94

Merged
merged 4 commits into from
Mar 24, 2022
Merged

update project files #94

merged 4 commits into from
Mar 24, 2022

Conversation

j-chad
Copy link
Contributor

@j-chad j-chad commented Mar 22, 2022

Description

Adds issue templates and updates the PR template to support our git checklist

Fixes/resolves #91

Screenshots

This document serves as an example of the updated PR template. Issue templates are the same as in FlatShare application.

Type of change

  • Improvement (non-breaking change which improves existing functionality)

Checklist:

Leave blank if not applicable

I have completed these steps when making this pull request:

  • I have checked that the PR is from a forked repository
  • I have assigned my name to the issue
  • I have moved the issue to the In Progress column
  • I have labelled the PR appropriately
  • I have assigned people responsible to the PR

Before opening the PR for review:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have moved the linked issue to the Review in Progress column

@j-chad j-chad added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 22, 2022
@j-chad j-chad self-assigned this Mar 22, 2022
fishmonger45
fishmonger45 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@fishmonger45 fishmonger45 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should configure this pull for frontend, or whatever we decide to do with the two repos fraser can do what he likes lol

@j-chad j-chad merged commit 574edd1 into SE701-T5:main Mar 24, 2022
@j-chad j-chad deleted the 91-update-project-files branch March 24, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishmonger45 fishmonger45 fishmonger45 approved these changes

Assignees

@j-chad j-chad

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update project files
2 participants
@j-chad @fishmonger45