Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Search Bar Component #164

Closed
shreyasingaraju opened this issue Mar 24, 2022 · 3 comments · Fixed by #182
Closed

Implement Search Bar Component #164

shreyasingaraju opened this issue Mar 24, 2022 · 3 comments · Fixed by #182
Assignees
@shreyasingaraju
Labels
design related to the design of the product feature New feature front-end related to front-end code
Projects
Frontend-A2

Comments

@shreyasingaraju
Copy link
Collaborator

shreyasingaraju commented Mar 24, 2022 •
edited

Is your feature request related to a problem? Please describe.
The search bar is currently not implemented on the frontend. The search feature will allow users to search for posts, topics and users.

image

Describe the solution you'd like
The solution will implement a search bar which will find matches based on a search request for specific posts, topics, users, etc. The results will be displayed in a list view for the user. The design should follow the Figma mock-ups.

The user can search in three categories: Top, Latest and People.

  • Top will show the best match search results.
  • Latest will show the most recent search results.
  • People will show any users who match the search.

This search feature will not implement a drop down of recommended search finds, it will only output the final search results.

Describe alternatives you've considered
n/a

Additional context
This issue was discussed, approved and allocated at the front-end team meeting on 24/03/22.
@shreyasingaraju shreyasingaraju added feature New feature front-end related to front-end code design related to the design of the product labels Mar 24, 2022
@shreyasingaraju shreyasingaraju self-assigned this Mar 24, 2022
@shreyasingaraju shreyasingaraju added this to To do in Frontend-A2 via automation Mar 24, 2022
@shreyasingaraju
Copy link
Collaborator Author

@arathibiju @KirstyGong Review please?

@KirstyGong
Copy link
Collaborator

LGTM!

@arathibiju
Copy link
Collaborator

@shreyasingaraju Maybe add a line about which meeting we discussed this issue but other wise looks good 😊

@shreyasingaraju shreyasingaraju mentioned this issue Mar 26, 2022
Merged
11 tasks
Frontend-A2 automation moved this from To do to Done Mar 27, 2022
shreyasingaraju added a commit that referenced this issue Mar 27, 2022
@shreyasingaraju
[#164] Implement Search Bar component (#182)
2223302 
* Added empty search page and search bar component

* Added text input

* Added back button

* Added onKeyPress for enter key

* Cleaned up code and added comments

* Removed .idea from config files and added .idea to gitignore

* Changed let text to useState. Added comments.

* Added commented note about console.log()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shreyasingaraju shreyasingaraju

Labels
design related to the design of the product feature New feature front-end related to front-end code
Projects
Frontend-A2
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#164] Implement Search Bar component shreyasingaraju/Updog
3 participants
@arathibiju @shreyasingaraju @KirstyGong