Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#159] banner popup #176

Merged
merged 4 commits into from
Mar 27, 2022
Merged

Conversation

KirstyGong
Copy link
Collaborator

@KirstyGong KirstyGong commented Mar 26, 2022

Description:

I added a banner setting pop up using the Mui dialog. The pop is now connected to the CHANGE BANEER IMAGE button. Currently mock data is been used for the default banner and it need to be replace when the endpoint is done.
image

All Submissions:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project
  • My code has been commented
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@KirstyGong KirstyGong self-assigned this Mar 26, 2022
@KirstyGong KirstyGong added feature New feature front-end related to front-end code labels Mar 26, 2022
@scorpionknifes scorpionknifes changed the title 159 banner popup [#159] banner popup Mar 26, 2022
@scorpionknifes scorpionknifes added this to In progress in Frontend-A2 via automation Mar 26, 2022
@scorpionknifes scorpionknifes removed this from In progress in Frontend-A2 Mar 26, 2022
Copy link
Collaborator

@arathibiju arathibiju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend/cypress/videos/BannerSetting_spec.js.mp4
What is this file from? Is it just generated by Cypress?
Looks good otherwise

@scorpionknifes
Copy link
Collaborator

frontend/cypress/videos/BannerSetting_spec.js.mp4 What is this file from? Is it just generated by Cypress? Looks good otherwise

Yeah they didn't setup cypress gitignore, can you add
to gitignore and remove the videos? ty

cypress/videos
cypress/screenshots

Copy link
Collaborator

@scorpionknifes scorpionknifes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to add gitignore. we can add methods to hook it up with backend later

@KirstyGong KirstyGong merged commit 975cf0b into SE701Team2:main Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature front-end related to front-end code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants