Move the "extras" data to be in their own profile netCDF file #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assumes that the "extras" data occurs before or after a profile and for now I think that is OK. This reduces the complexity of the code quite a bit. We just make the "extras" data look like a profile dataset, optionally setting the depths to zero if there are no depths to capture the data as surface measurements. This also changes some of the extras configuration kwarg names so we can control the creation of the ASCII pseudogram and the inclustion of that data into the netCDF profile files, and the image creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes that the "extras" data occurs before or after a profile
and for now I think that is OK. This reduces the complexity of the
code quite a bit. We just make the "extras" data look like a profile
dataset, optionally setting the depths to zero if there are no depths
to capture the data as surface measurements.
This also changes some of the extras configuration kwarg names so we
can control the creation of the ASCII pseudogram and the inclustion
of that data into the netCDF profile files, and the image creation.