Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for iterating over data needed (e.g. iterating over DataGenerators in RepeatedTasks) #48

Closed
matthiaskoenig opened this issue Sep 29, 2017 · 3 comments

Comments

@matthiaskoenig
Copy link
Collaborator

matthiaskoenig commented Sep 29, 2017

Issue

In L1V3 it is possible to read data and plot it, i.e. generate a DataGenerator and use it for output. What is missing is a solution to parametrize simulations/tasks, i.e. use the data within the tasks/simulations.
This is the very important use case of storing parameter sets and sets of initial concentrations in data files and than drive the model with this data.
Somehow it is not possible with the current specification to iterate over a dataGenerators in a range.

This would also be very helpful to iterate over data in DataGenerators from other sources and provide very interesting functionality:

Examples

A classical example would be

Proposals

Introduce an additional range which allows to iterate over a dataGenerator, i.e. would iterate over all values in the dataGenerator

DataGeneratorRange(Range):
    dataSource: SIdRef (DataGenerator)

Such a DataGeneratorRange would allow to define repeated tasks based on Data in DataGenerators. No circular referencing would be allowed.

Ranges:
https://docs.google.com/drawings/d/1bgGu_Pty0k_8xX2CS611rmP33jZTVbW326FIgFPXRzc/edit

@matthiaskoenig matthiaskoenig self-assigned this Sep 29, 2017
@matthiaskoenig matthiaskoenig added this to the L1V3 Release milestone Sep 29, 2017
@matthiaskoenig matthiaskoenig added L1V4 and removed L1V3 labels Sep 29, 2017
@matthiaskoenig matthiaskoenig changed the title Add FunctionalRange example with DataSource Provide range over DataSource, i.e. iterating over data in repeated tasks Sep 29, 2017
@matthiaskoenig matthiaskoenig removed their assignment Sep 29, 2017
@matthiaskoenig matthiaskoenig changed the title Provide range over DataSource, i.e. iterating over data in repeated tasks Solution for iterating over data needed (e.g. iterating over DataSources in RepeatedTasks) Sep 30, 2017
@matthiaskoenig matthiaskoenig changed the title Solution for iterating over data needed (e.g. iterating over DataSources in RepeatedTasks) Solution for iterating over data needed (e.g. iterating over DataGenerators in RepeatedTasks) Sep 30, 2017
@luciansmith
Copy link
Contributor

HARMONY 2018: This should already be possible with the use of a DataSource within a DataDescription. Within a RepeatedTask, the SetValue will reference the DataSource #id.

@luciansmith
Copy link
Contributor

You also have to use FunctionalRange to tell the repeated task how many times to repeat.

@luciansmith
Copy link
Contributor

As far as I can tell, this issue has indeed been addressed (and beyond) and everything should be possible in l1v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants