Catch the socket.error exception when trying to get the hostname

This is the base exception for all errors in the socket library. Explicit
is better than implicit!

Signed-off-by: Jeff Schroeder <jeffschroeder@computer.org>

jaeger_client/tracer.py

@@ -84,13 +84,12 @@ def __init__(
         }
         if tags:
             self.tags.update(tags)
-        # noinspection PyBroadException
 
         if self.tags.get(constants.JAEGER_HOSTNAME_TAG_KEY) is None:
             try:
                 hostname = socket.gethostname()
                 self.tags[constants.JAEGER_HOSTNAME_TAG_KEY] = hostname
-            except:
+            except socket.error:
                 logger.exception('Unable to determine host name')
 
         self.reporter.set_process(

tests/test_tracer.py

@@ -15,6 +15,7 @@
 import mock
 import random
 import six
+import socket
 
 import pytest
 import tornado.httputil
@@ -200,7 +201,7 @@ def test_tracer_tags_no_hostname():
     from jaeger_client.tracer import logger
     with mock.patch.object(logger, 'exception') as mock_log:
         with mock.patch('socket.gethostname',
-                        side_effect=['host', ValueError()]):
+                        side_effect=['host', socket.timeout()]):
             Tracer(service_name='x', reporter=reporter, sampler=sampler)
         assert mock_log.call_count == 1