Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between projection onto grid and edge intersection #66

Open
chrisnatali opened this issue Jul 14, 2015 · 1 comment
Open

Comments

@chrisnatali
Copy link
Contributor

Projection uses spherical calculations whereas edge intersection test uses euclidean space.

For now we use a tolerance in the edge intersection test that suffices on our scale, but it would be best to perform the projection and intersection test using the same math.

@chrisnatali
Copy link
Contributor Author

"Projection" here refers to the projection of demand nodes onto existing grid done in geograph project_onto. This CAN use a spherical space, but no longer does by default.

"edge intersection" refers to the test to detect whether a candidate edge geometrically intersects with a previously added edge in the modified minimum spanning tree algorithm (geometric intersection is considered a new connection which introduces a cycle...and we can't have cycles). This is called in mod_boruvka here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant