Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune performance of angular <-> cartesian conversions #82

Open
chrisnatali opened this issue Apr 14, 2016 · 5 comments
Open

Tune performance of angular <-> cartesian conversions #82

chrisnatali opened this issue Apr 14, 2016 · 5 comments

Comments

@chrisnatali
Copy link
Contributor

No description provided.

@chrisnatali
Copy link
Contributor Author

Happens much faster in bulk.

@vr2262
Copy link

vr2262 commented May 4, 2016

I assume you mean the functions in here? /networker/geomath.py

@chrisnatali
Copy link
Contributor Author

Yah. The spherical point project on segment function was much slower than the corresponding cartesian point projection.

A lot had to do with the angular to 3-space coordinate conversion...it ran faster when done in bulk, but it was difficult to bulk them in the context of finding the nearest point on a segment. I tried.

So I decided to revert to cartesian based projection onto segment by default (even for angular coordinates) and add a configuration option for doing this spherically. This is how it was done in legacy versions and it hasn't introduced a lot of error thus far.

@vr2262
Copy link

vr2262 commented May 10, 2016

So... is it worth continued effort to improve the spherical version?

@chrisnatali
Copy link
Contributor Author

It's a low priority at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants