This repository has been archived by the owner on May 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [org.springframework.boot](https://github.com/spring-projects/spring-boot) from 2.6.5 to 2.6.6. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.6.5...v2.6.6) --- updated-dependencies: - dependency-name: org.springframework.boot dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.17.0 to 5.18.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.18.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nd (#189) Bumps [eslint-import-resolver-typescript](https://github.com/alexgorbatchev/eslint-import-resolver-typescript) from 2.7.0 to 2.7.1. - [Release notes](https://github.com/alexgorbatchev/eslint-import-resolver-typescript/releases) - [Changelog](https://github.com/alexgorbatchev/eslint-import-resolver-typescript/blob/master/CHANGELOG.md) - [Commits](import-js/eslint-import-resolver-typescript@v2.7.0...v2.7.1) --- updated-dependencies: - dependency-name: eslint-import-resolver-typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…end (#190) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.17.0 to 5.18.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.18.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [prettier](https://github.com/prettier/prettier) from 2.6.1 to 2.6.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.6.1...2.6.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-endpoint Implement project endpoint
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.25.4 to 2.26.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.25.4...v2.26.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* (broken) first try at #183 * (broken) Coach has no need to view all suggestions * (broken) Introduce more wizards * fix tests and add documentation * resolve changes requested by @KasperDemeyere
* (broken) first edition auth implementation * (broken)(linter)working tests thanks to @KasperDemeyere * fix all tests and linter * use like instead of = in findByName from edition
* (broken) add testfile * add coach tests * add base tests
* Add setup for I18N/String resource files * Check if prettier works now * Check if it works now * Add home page title to resource file
* added tests for invitation and InvitationRepository * requested changes
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.43 to 18.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* (broken) first go add implemnting student repo * (broken) implement student to json * (broken) should still fix suugestion that can e null * (broken) ready native query * (broken) working query and test! Party! * pronoun ready student * Resolve changes requested by @KasperDemeyere
* (broken) setup login frontend * (broken) setup login frontend * (broken) working login frontend * (broken) working login frontend * (broken) handle login errors * Fix linter errors * (broken) login tests * Fix test * Fix test * Fix test for loginForm component * Fix test for loginForm component * Mock axios and add tests + overige testen * Mock axios and add tests + overige testen * (broken) fix dependency errors * remove redundant change * Fix broken test * Fix broken test + mock Router * Remove first-test and removableHelper * Apply requested changes and rebase from development * Apply requested changes and rebase from development * Fix the failing tests caused by the translations * Fix the failing tests caused by the translations * Add csrf comment * Remove forgotten react-i18next-mock and unused packages * Use translation on index page * Use translation on index page * Add requested changes and fix tests * Alter hard coded "empty page" * Update frontend/i18n.js Added comment Co-authored-by: Jitse De Smet <35114273+jitsedesmet@users.noreply.github.com> * Requested adaptions for linter * rename translations to common * Fix tsconfig * Fix tsconfig Co-authored-by: Jitse De Smet <35114273+jitsedesmet@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 8.12.0 to 8.13.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.12.0...v8.13.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-tsdoc](https://github.com/microsoft/tsdoc/tree/HEAD/eslint-plugin) from 0.2.14 to 0.2.16. - [Release notes](https://github.com/microsoft/tsdoc/releases) - [Changelog](https://github.com/microsoft/tsdoc/blob/main/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/microsoft/tsdoc/commits/HEAD/eslint-plugin) --- updated-dependencies: - dependency-name: eslint-plugin-tsdoc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* registration invitation token handling (untested) * add testing, base admin loading, exception wizard * add file to action runner * add missing test, removed empty check * Update backend/src/main/java/com/osoc6/OSOC6/winterhold/MeguminExceptionWizard.java Co-authored-by: Jitse De Smet <35114273+jitsedesmet@users.noreply.github.com> * requested changes * fix possible base user bugs * update docs, remove password from json * add documentation about initial admin user Co-authored-by: Jitse De Smet <35114273+jitsedesmet@users.noreply.github.com>
* auth enable ProjectSkill + test * Ready student skills * Impelemntation of user skill & tests * remove transactional annotation * rename some tests * resolve changes requested by @KasperDemeyere
* NavBar with new string-resource handling * Move string resources to common.json; delete navBar.json * Change 'fixed' to 'sticky' as requested * Add icons in public folder to NavBar * Use svg for profile icon * Add newline to profile-icon.svg
* implement auth enabeled Communication endpoint * Use JSON ignore instead of not referencing communication in Student * student should not contain test string * Resolve change requested by @lvrossem * Resolve changes requested by @KasperDemeyere
* Fix dependencies
… form (#531) * Add more input validation for email and URI's * Add URI-function to utility
* add confirm delete button component * prettier * merge * prettier * use confirmdeletebutton * prettier * merge
* I hope this fixes the background issue * fix styling issue
Change edition on url control by @jitsedesmet
* very small styling to skilltype pages * fix big button * prettier
Bugfixes projects
Mutate over edit and create buttons
* fix reset component button * prettier
* Start of the great Swagger rewrite * Try fixing broken setup * Add conflict request to Swagger * Should be the last version of Swagger
Show the login error
Navbar when not logged in
Act around mockAxios
* Add URI validation to form * Fix Syntax error following conflict resolution
|
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 89.33% (+21.06% 🔼) |
2770/3101 |
🟡 | Branches | 72.11% (+14.65% 🔼) |
636/882 |
🟢 | Functions | 85.65% (+21.37% 🔼) |
406/474 |
🟢 | Lines | 88.91% (+19.48% 🔼) |
2390/2688 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | ... / create.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / navBar.tsx |
100% | 100% | 100% | 100% |
🟢 | hooks/utilHooks.ts | 92.31% | 33.33% | 90% | 91.67% |
🟢 | ... / useGlobalEdition.ts |
100% | 100% | 100% | 100% |
🔴 | ... / globalContext.tsx |
26.67% | 0% | 0% | 33.33% |
🟢 | ... / optionsMenu.tsx |
85.71% | 0% | 50% | 85% |
🟢 | ... / useCurrentUser.ts |
100% | 83.33% | 100% | 100% |
🟢 | ... / projectForm.tsx |
97.67% | 88.1% | 100% | 97.1% |
🟢 | ... / projectFormSubmitHandler.ts |
97.06% | 66.67% | 100% | 96.3% |
🟢 | ... / createCoachSubForm.tsx |
93.48% | 81.25% | 100% | 91.67% |
🟢 | ... / confirmDeleteButton.tsx |
100% | 66.67% | 100% | 100% |
🟢 | ... / createProjectSkillSubForm.tsx |
92.16% | 66.67% | 90% | 91.11% |
🟢 | ... / skillBadge.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / useSkillTypeByName.ts |
100% | 90% | 100% | 100% |
🟢 | ... / editProjectSkillSubForm.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / itemListForm.tsx |
100% | 100% | 100% | 100% |
🟡 | ... / routerHooks.ts |
64.29% | 22.22% | 100% | 64.29% |
🟢 | ... / background.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / edit.tsx |
90% | 66.67% | 100% | 88.89% |
🟢 | ... / createStudentForm.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / createStudentSubmitHandler.ts |
100% | 100% | 100% | 100% |
🟢 | ... / create.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / studentList.tsx |
92.59% | 76.47% | 90% | 90.91% |
🟢 | ... / suggestionCount.tsx |
88.89% | 80% | 100% | 87.5% |
🟢 | ... / studentFilterComponent.tsx |
93.94% | 93.75% | 83.33% | 93.44% |
🟢 | ... / studentStatusButton.tsx |
96.3% | 84.62% | 80% | 95.65% |
🟢 | ... / useQueriedStudents.ts |
100% | 100% | 100% | 100% |
🟢 | ... / studentInfo.tsx |
94.03% | 90.91% | 71.43% | 93.1% |
🟢 | ... / suggestionModal.tsx |
88.89% | 83.33% | 66.67% | 89.29% |
🟢 | ... / suggestionCalls.ts |
80% | 50% | 66.67% | 88.89% |
🟢 | ... / studentStatus.tsx |
92.31% | 100% | 66.67% | 90.91% |
🟢 | ... / studentStatusModal.tsx |
88.24% | 100% | 75% | 92.31% |
🟢 | ... / suggestionListItem.tsx |
89.47% | 66.67% | 100% | 87.5% |
🟡 | ... / editionInfo.tsx |
75% | 71.43% | 72.73% | 72.62% |
🟢 | ... / projectSkillItem.tsx |
96.72% | 85.71% | 87.5% | 95.74% |
🟢 | ... / warningToast.tsx |
91.67% | 100% | 50% | 90% |
🟢 | ... / studentAssignmentsRow.tsx |
86.96% | 66.67% | 66.67% | 85.71% |
🟢 | ... / assignmentReasonListItem.tsx |
91.67% | 75% | 100% | 90% |
🟢 | ... / studentAssignmentRegister.tsx |
94.74% | 85.71% | 100% | 94.12% |
🟢 | ... / useValidAssignmentsFromProjectSkillList.ts |
100% | 50% | 100% | 100% |
🟢 | ... / createCommunicationForm.tsx |
100% | 83.33% | 100% | 100% |
🟢 | ... / createCommunicationSubmitHandler.ts |
100% | 100% | 100% | 100% |
🟢 | ... / communicationCalls.ts |
91.67% | 100% | 75% | 90.91% |
🟢 | utility/mailTo.ts | 100% | 100% | 100% | 100% |
🟢 | ... / projectInfo.tsx |
87.5% | 75.76% | 66.67% | 85.71% |
🟢 | ... / useFullProjectInfo.ts |
100% | 100% | 100% | 100% |
🟢 | ... / projectSkillStudent.tsx |
85.19% | 66.67% | 100% | 80.95% |
🟢 | ... / useProjectsByEdition.ts |
100% | 100% | 100% | 100% |
🟢 | ... / registerCommunication.tsx |
100% | 94.74% | 100% | 100% |
🟢 | ... / createCommunicationTemplateForm.tsx |
91.18% | 78.57% | 100% | 90.32% |
🟢 | ... / createCommunicationTemplateSubmitHandler.ts |
100% | 100% | 100% | 100% |
🟢 | ... / communicationTemplateCalls.ts |
93.33% | 100% | 80% | 92.31% |
🟢 | ... / usersOverview.tsx |
85.71% | 66.67% | 50% | 84.21% |
🟢 | ... / manageUserComponent.tsx |
95.45% | 94.44% | 85.71% | 94.44% |
🟢 | ... / invitationButton.tsx |
95.65% | 71.43% | 100% | 94.29% |
🟢 | ... / invitationCalls.ts |
100% | 100% | 100% | 100% |
🟢 | ... / applicationProperties.ts |
100% | 100% | 100% | 100% |
🟢 | ... / conflictResolutionList.tsx |
88.24% | 66.67% | 100% | 86.67% |
🟢 | ... / conflictResolutionItem.tsx |
87.01% | 80% | 92.31% | 87.93% |
🟢 | ... / conflictResolutionRadioButton.tsx |
87.5% | 71.43% | 75% | 85.29% |
🟢 | ... / projectSkillRegister.tsx |
91.67% | 41.3% | 100% | 90.91% |
🟢 | ... / useValidAssignmentsFromStudentList.ts |
100% | 100% | 100% | 100% |
🟢 | ... / useConflictStudents.ts |
100% | 100% | 100% | 100% |
🟡 | ... / resetComponent.tsx |
80.95% | 71.43% | 33.33% | 78.13% |
🟢 | ... / assignmentModal.tsx |
97.44% | 80% | 100% | 97.06% |
🟡 | ... / assignmentSkillList.tsx |
81.82% | 77.78% | 50% | 79.31% |
🟢 | ... / loginForm.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / profileOverview.tsx |
93.22% | 85.71% | 83.33% | 91.84% |
🟢 | ... / index.tsx |
92% | 66.67% | 100% | 91.3% |
🟢 | ... / skillTypeList.tsx |
77.78% | 33.33% | 80% | 81.25% |
🟢 | ... / skillTypeListItem.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / registrationForm.tsx |
86.84% | 100% | 50% | 85.29% |
🟢 | ... / projectList.tsx |
93.75% | 75% | 100% | 92.86% |
🟢 | ... / newProjectButton.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / studentCommunicationList.tsx |
84.38% | 76.92% | 75% | 82.76% |
🟢 | ... / communicationListItem.tsx |
89.47% | 66.67% | 100% | 87.5% |
🟢 | ... / index.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / editionList.tsx |
87.5% | 60% | 50% | 86.36% |
🟢 | ... / editionRowComponent.tsx |
86% | 62.5% | 60% | 84.44% |
🟢 | ... / routeInjector.tsx |
86.67% | 59.02% | 66.67% | 84.31% |
🟢 | utility/pathUtil.ts | 94.44% | 50% | 100% | 93.75% |
🟢 | ... / create.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / skillTypeForm.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / createSkillTypeSubmitHandler.ts |
100% | 100% | 100% | 100% |
🟢 | ... / resetPassword.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / forbiddenCoachRoutes.ts |
100% | 100% | 100% | 100% |
🟢 | ... / create.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / createEditionForm.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / editionHandler.ts |
100% | 100% | 100% | 100% |
🟢 | ... / projectAssignmentList.tsx |
96% | 75% | 100% | 95.65% |
🟢 | ... / forgotPassword.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / forgotComponent.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / routeGuard.tsx |
100% | 100% | 100% | 100% |
🟢 | ... / edit.tsx |
90.91% | 66.67% | 100% | 90% |
🟢 | ... / index.tsx |
100% | 100% | 100% | 100% |
🔴 | ... / useCompleteCommunication.ts |
0% | 0% | 0% | 0% |
🔴 | ... / useFullSuggestion.ts |
0% | 0% | 0% | 0% |
🔴 | ... / [id].tsx |
0% | 100% | 0% | 0% |
🔴 | ... / register-communication.tsx |
0% | 100% | 0% | 0% |
🔴 | ... / communications.tsx |
0% | 0% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | ... / stringUtil.ts |
85.71% (-14.29% 🔻) |
100% | 66.67% (-33.33% 🔻) |
85.71% (-14.29% 🔻) |
🟢 | ... / projectCalls.ts |
100% | 75% (-25% 🔻) |
100% | 100% |
🟢 | ... / projectSkillCalls.ts |
94.12% (+10.78% 🔼) |
71.43% (-28.57% 🔻) |
80% (+30% 🔼) |
93.75% (+10.42% 🔼) |
🟡 | ... / SkillTypeEntity.ts |
60% (-11.43% 🔻) |
100% | 66.67% (+16.67% 🔼) |
66.67% |
🟢 | ... / skillTypeCalls.ts |
85.71% (+8.79% 🔼) |
75% (-25% 🔻) |
75% (+25% 🔼) |
88.89% (+11.97% 🔼) |
🟢 | ... / AssignmentCalls.ts |
86.67% (-13.33% 🔻) |
60% (-40% 🔻) |
88.89% (-11.11% 🔻) |
88.89% (-11.11% 🔻) |
🟢 | pages/login.tsx | 95.45% (-4.55% 🔻) |
100% | 50% (-50% 🔻) |
95% (-5% 🔻) |
🟢 | ... / loginSubmitHandler.tsx |
100% | 33.33% (-16.67% 🔻) |
100% | 100% |
🟢 | ... / assignStudents.tsx |
87.88% (-12.12% 🔻) |
28.57% (-71.43% 🔻) |
33.33% (-66.67% 🔻) |
84% (-16% 🔻) |
🔴 | ... / UserSkillEntity.ts |
0% (-57.14% 🔻) |
100% | 0% (-50% 🔻) |
0% (-50% 🔻) |
Test suite run success
180 tests passing in 45 suites.
Report generated by 🧪jest coverage report action from e67e052
ruvmello
approved these changes
May 22, 2022
andpuydt
approved these changes
May 22, 2022
jitsedesmet
approved these changes
May 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.