This repository has been archived by the owner on May 24, 2022. It is now read-only.
ready #559
Merged
ready #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end (#190) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.17.0 to 5.18.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.18.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [prettier](https://github.com/prettier/prettier) from 2.6.1 to 2.6.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.6.1...2.6.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-endpoint Implement project endpoint
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.25.4 to 2.26.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.25.4...v2.26.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* (broken) first try at #183 * (broken) Coach has no need to view all suggestions * (broken) Introduce more wizards * fix tests and add documentation * resolve changes requested by @KasperDemeyere
* (broken) first edition auth implementation * (broken)(linter)working tests thanks to @KasperDemeyere * fix all tests and linter * use like instead of = in findByName from edition
* (broken) add testfile * add coach tests * add base tests
* Add setup for I18N/String resource files * Check if prettier works now * Check if it works now * Add home page title to resource file
* added tests for invitation and InvitationRepository * requested changes
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.43 to 18.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* (broken) first go add implemnting student repo * (broken) implement student to json * (broken) should still fix suugestion that can e null * (broken) ready native query * (broken) working query and test! Party! * pronoun ready student * Resolve changes requested by @KasperDemeyere
* (broken) setup login frontend * (broken) setup login frontend * (broken) working login frontend * (broken) working login frontend * (broken) handle login errors * Fix linter errors * (broken) login tests * Fix test * Fix test * Fix test for loginForm component * Fix test for loginForm component * Mock axios and add tests + overige testen * Mock axios and add tests + overige testen * (broken) fix dependency errors * remove redundant change * Fix broken test * Fix broken test + mock Router * Remove first-test and removableHelper * Apply requested changes and rebase from development * Apply requested changes and rebase from development * Fix the failing tests caused by the translations * Fix the failing tests caused by the translations * Add csrf comment * Remove forgotten react-i18next-mock and unused packages * Use translation on index page * Use translation on index page * Add requested changes and fix tests * Alter hard coded "empty page" * Update frontend/i18n.js Added comment Co-authored-by: Jitse De Smet <35114273+jitsedesmet@users.noreply.github.com> * Requested adaptions for linter * rename translations to common * Fix tsconfig * Fix tsconfig Co-authored-by: Jitse De Smet <35114273+jitsedesmet@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 8.12.0 to 8.13.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.12.0...v8.13.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-tsdoc](https://github.com/microsoft/tsdoc/tree/HEAD/eslint-plugin) from 0.2.14 to 0.2.16. - [Release notes](https://github.com/microsoft/tsdoc/releases) - [Changelog](https://github.com/microsoft/tsdoc/blob/main/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/microsoft/tsdoc/commits/HEAD/eslint-plugin) --- updated-dependencies: - dependency-name: eslint-plugin-tsdoc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* registration invitation token handling (untested) * add testing, base admin loading, exception wizard * add file to action runner * add missing test, removed empty check * Update backend/src/main/java/com/osoc6/OSOC6/winterhold/MeguminExceptionWizard.java Co-authored-by: Jitse De Smet <35114273+jitsedesmet@users.noreply.github.com> * requested changes * fix possible base user bugs * update docs, remove password from json * add documentation about initial admin user Co-authored-by: Jitse De Smet <35114273+jitsedesmet@users.noreply.github.com>
* auth enable ProjectSkill + test * Ready student skills * Impelemntation of user skill & tests * remove transactional annotation * rename some tests * resolve changes requested by @KasperDemeyere
* NavBar with new string-resource handling * Move string resources to common.json; delete navBar.json * Change 'fixed' to 'sticky' as requested * Add icons in public folder to NavBar * Use svg for profile icon * Add newline to profile-icon.svg
* implement auth enabeled Communication endpoint * Use JSON ignore instead of not referencing communication in Student * student should not contain test string * Resolve change requested by @lvrossem * Resolve changes requested by @KasperDemeyere
* Fix dependencies
* Implement auth enabled assignment endpoint & tests * student conflict endpoint & tests * fix time test * Resolve changes requested by @KasperDemeyere Co-authored-by: Kasper Demeyere <kasperdemeyere@hotmail.com>
* (broken) setup login frontend * (broken) handle login errors * (broken) login tests * Fix test * Fix test for loginForm component * Fix test for loginForm component * Mock axios and add tests + overige testen * Mock axios and add tests + overige testen * Apply requested changes and rebase from development * Apply requested changes and rebase from development * Fix the failing tests caused by the translations * Fix the failing tests caused by the translations * Add requested changes and fix tests * rename translations to common * Fix tsconfig * Fix tsconfig * Change json to ts * Change json to ts * Remove hardcoded url * Use correct login url * Use correct login url * Add baseurl * Add baseurl
* (broken) implement find own user endpoint * fix broken test * add path
* creating edition * implement pages * fix pages * (broken) major code cleanup * fix tests * add user skill * prettier * ready communicationTemplate * rename file
* implement student * prittier * skilltype injection * rewrite login using axios * invitation * Add user and assignments * pretty * hope to revive action (and did) * Update backend/src/main/java/com/osoc6/OSOC6/database/models/Project.java Co-authored-by: Kasper Demeyere <68854162+KasperDemeyere@users.noreply.github.com> Co-authored-by: Kasper Demeyere <68854162+KasperDemeyere@users.noreply.github.com>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.18.0 to 5.19.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.19.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* bugfix * prettier + auto scale dependencies
* fix reset component button * prettier
* Start of the great Swagger rewrite * Try fixing broken setup * Add conflict request to Swagger * Should be the last version of Swagger
Show the login error
Navbar when not logged in
Act around mockAxios
* Add URI validation to form * Fix Syntax error following conflict resolution
* clone all again * emerge from the death - injector
* boost skill type coverage * prettier
* fix navbar tests * prettier
ruvmello
previously approved these changes
May 22, 2022
|
ruvmello
approved these changes
May 22, 2022
KasperDemeyere
approved these changes
May 22, 2022
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 89.62% | 2807/3132 |
| 🟡 | Branches | 72.32% | 640/885 |
| 🟢 | Functions | 86.11% | 409/475 |
| 🟢 | Lines | 89.18% | 2422/2716 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | pages/inject.tsx | 100% | 100% | 100% | 100% |
| 🟢 | ... / dataInjectionHandler.ts |
100% | 100% | 100% | 100% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / suggestionModal.tsx |
83.72% (-5.17% 🔻) |
66.67% (-16.67% 🔻) |
66.67% | 84.38% (-4.91% 🔻) |
Test suite run success
187 tests passing in 46 suites.
Report generated by 🧪jest coverage report action from aec3134
andpuydt
approved these changes
May 22, 2022
|
1 similar comment
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.