Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate dependency resolution issue with JUnit #82

Closed
TimvdLippe opened this issue Apr 28, 2016 · 6 comments
Closed

Investigate dependency resolution issue with JUnit #82

TimvdLippe opened this issue Apr 28, 2016 · 6 comments

Comments

@TimvdLippe
Copy link
Contributor

TimvdLippe commented Apr 28, 2016

There appears to be a dependency resolution issue with JUnit. Cucumber 1.2.4 requires JUnit 4.11, whereas the framework requires JUnit 4.12.

There seem to be two possible solutions:

  1. Exclude the JUnit dependency on Cucumber in the pom.xml
  2. Bump cucumber to version 1.2.5-SNAPSHOT which does depend on JUnit 4.12 (originally junit 4.12 broke compatibility with android) See Investigate dependency resolution issue with JUnit #82 (comment)
@avandeursen
Copy link
Member

I'd say updating the dependency (to 1.2.5-SNAPSHOT) is the best thing to do, and then bump to 1.2.5 as soon as it is available.

@jwgmeligmeyling
Copy link
Member

Dependency divergence in the minor part of the version number, for test scoped dependencies, doesn't seem any problem to me? Otherwise we would be writing [version] everywhere in our pom.xml versions, right?

@TimvdLippe
Copy link
Contributor Author

Option 2 appears to be impossible, as 1.2.5-SNAPSHOT is not published on the mvn repository and therefore mvn install will fail with the message

[ERROR] Failed to execute goal on project jpacman-framework: Could not resolve dependencies for project nl.tudelft.jpacman:jpacman-framework:jar:6.4.0: The following artifacts could not be resolved: info.cukes:cucumber-java:jar:1.2.5-SNAPSHOT, info.cukes:cucumber-junit:jar:1.2.5-SNAPSHOT: Could not find artifact info.cukes:cucumber-java:jar:1.2.5-SNAPSHOT -> [Help 1]

@TimvdLippe
Copy link
Contributor Author

Cucumber 1.2.5 has been released and uses JUnit 4.12

@TimvdLippe
Copy link
Contributor Author

We probably need to see if there again problems with the adoption of JUnit 5 per #99

@avandeursen
Copy link
Member

Thanks! We're using Cucumber 1.2.5 now, and it works. It does still rely on good old JUnit 4 and its RunWith extensions at the moment, but that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants