Remove collaborator card heading #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lace H2 to fix accessibility issue with confusing heading order
prescod
reviewed
Apr 11, 2023
| fireEvent.click(getByTitle('Remove')); | ||
| fireEvent.click( | ||
| getByTitle( | ||
| `Remove ${sampleGitHubUser2.name} (${sampleGitHubUser2.login})`, |
There was a problem hiding this comment.
I don't see the stuff in parentheses in the title:
`Remove ${sampleGitHubUser2.name} (${sampleGitHubUser2.login})`,
Why?
There was a problem hiding this comment.
Ah, name is set above on line 23:
let name: string | JSX.Element = user.name
? `${user.name} (${user.login})`
: user.login;
prescod
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap default SLDS
<card>react component with basic SLDS markup to remove an out of place H2. This is to fix an accessibility issue with confusing heading order.In addition, I also fixed another potential issue, with each collaborator listed having the same title of "Remove", this would be confusing for users, so I made sure each button specifies which user would be deleted. This change required a simple update to the test.