Merge pull request #6 from SFDO-Tooling/i18n-cleanup

Change the format for i18n to something more YAMLishous.

snowfakery/data_generator_runtime.py

@@ -328,7 +328,6 @@ def simple_field_vars(self):
             "this": obj,
             "today": interpreter.globals.today,
             "fake": interpreter.faker_template_library,
-            "fake_i18n": lambda locale: FakerTemplateLibrary(locale),
             **interpreter.options,
             **interpreter.globals.object_names,
             **(obj._values if obj else {}),

snowfakery/template_funcs.py

@@ -101,6 +101,11 @@ def date_between(self, *, start_date, end_date):
                     raise
             # swallow empty range errors per Python conventions
 
+        def i18n_fake(self, locale: str, fake: str):
+            faker = Faker(locale)
+            func = getattr(faker, fake)
+            return func()
+
         def random_number(self, min: int, max: int) -> int:
             """Pick a random number between min and max like Python's randint."""
             return random.randint(min, max)

tests/CharacterGenTest.yml

@@ -6,7 +6,10 @@
 - object: Druid
   count: <<num_druids>>
   fields:
-    Name: <<fake_i18n('de_DE').first_name()>>
+    Name:
+      i18n_fake:
+        locale: no_NO
+        fake: first_name
     Level: <<random_number(1,10)>>
     Strength:
       random_number:
@@ -88,7 +91,10 @@
 - object: Fighter
   count: <<num_fighters>>
   fields:
-    Name: <<fake_i18n('no_NO').first_name()>>
+    Name:
+      i18n_fake:
+        locale: ja_JP
+        fake: first_name
     Level: <<random_number(1,10)>>
     Strength:
       random_number:
@@ -172,7 +178,10 @@
 
 - object: Paladin
   fields:
-    Name: <<fake_i18n('nl_NL').first_name()>>
+    Name:
+      i18n_fake:
+        locale: nl_NL
+        fake: first_name
     Level: 10 # fixme
     Strength:
       random_number:

tests/i18n.yml

@@ -0,0 +1,7 @@
+- object: foo
+  count: 10
+  fields:
+    japanese_name:
+        i18n_fake:
+            locale: ja_JP
+            fake: name

tests/test_i18n.py

@@ -0,0 +1,25 @@
+from io import StringIO
+from unittest import mock
+
+from snowfakery.data_generator import generate
+
+write_row_path = "snowfakery.output_streams.DebugOutputStream.write_row"
+
+
+def row_values(write_row_mock, index, value):
+    return write_row_mock.mock_calls[index][1][1][value]
+
+
+class Testi18n:
+    @mock.patch(write_row_path)
+    def test_i18n(self, write_row_mock):
+        yaml = """
+        - object: foo
+          fields:
+            japanese_name:
+                i18n_fake:
+                    locale: ja_JP
+                    fake: name"""
+        generate(StringIO(yaml), {})
+        assert isinstance(row_values(write_row_mock, 0, "japanese_name"), str)
+