New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the audio recording tutorial. #41
Conversation
<p> | ||
If you have multiple sound input devices connected to your computer (for example a microphone, a sound interface (external soundcard) or a | ||
webcam microphone) you can specify the device that is used for recording. A sound input device is identified by its name. | ||
A <code>std::vector<std::string></code> containing the names of all connected devices is available through the static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't <
and >
be escaped with <
and >
respectively?
Cool! I'll try to translate it tomorrow if no one did it before then. |
e46ee6d
to
b85cddc
Compare
Fixed the mistakes. |
Here is a small example of how to set the input device: | ||
</p> | ||
<pre><code class="cpp">// get the available sound input device names | ||
std::vector<std::string> availableDevices = sf::SoundRecorder::getAvailableDevices(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too <
and >
need to be escaped. =P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Feel free to squash the two commits. 😉 |
@@ -72,6 +72,36 @@ | |||
If you want to use the captured audio data after the recorder is destroyed or restarted, don't forget to make a <em>copy</em> of the buffer. | |||
</p> | |||
|
|||
<?php h2('Selecting the input device') ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sélectionner le périphérique d'entrée
Here, now you've got a translation (@LaurentGomila si tu vois des erreurs, n'hésite pas à me taper dessus =P) |
I edited your messages directly. You made the initial translation effort, so... I won't bash you this time. Seriously, there were only a few minor mistakes, good job ;) |
Awesome! Thank you guys for the translation 👍. I will add it tomorrow and squash everything into one commit. Then it should be ready for a final review. |
@LaurentGomila haha thank you! :D |
Ok I added the french translation and squased the commit. I added an error check to the example. But I don't know if I got the french translation right... 😃 |
"ratée" is too familiar for this context.
(don't forget the extra space before the colon) |
Also added a section about selection of the input device. French translation by mantognini.
Ok thanks. I fixed it. |
I updated the 2.2 and 2.3 audio recording tutorial. I added a new section on how to select the sound input device and rewrote a red box that is no longer valid. Also added some missig
sf::
to the example codes.I think I've got all the tags right, but I don't have a webserver to test on, so it would be nice if somebody could verify that.