Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the audio recording tutorial. #41

Merged
merged 1 commit into from Sep 29, 2015
Merged

Conversation

Foaly
Copy link
Contributor

@Foaly Foaly commented Sep 27, 2015

I updated the 2.2 and 2.3 audio recording tutorial. I added a new section on how to select the sound input device and rewrote a red box that is no longer valid. Also added some missig sf:: to the example codes.

I think I've got all the tags right, but I don't have a webserver to test on, so it would be nice if somebody could verify that.

<p>
If you have multiple sound input devices connected to your computer (for example a microphone, a sound interface (external soundcard) or a
webcam microphone) you can specify the device that is used for recording. A sound input device is identified by its name.
A <code>std::vector<std::string></code> containing the names of all connected devices is available through the static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't < and > be escaped with &lt; and &gt; respectively?

@mantognini
Copy link
Member

Cool! I'll try to translate it tomorrow if no one did it before then.

@Foaly Foaly force-pushed the patch-1 branch 3 times, most recently from e46ee6d to b85cddc Compare September 27, 2015 21:37
@Foaly
Copy link
Contributor Author

Foaly commented Sep 27, 2015

Fixed the mistakes.
That would be awesome! Thank you!

Here is a small example of how to set the input device:
</p>
<pre><code class="cpp">// get the available sound input device names
std::vector<std::string> availableDevices = sf::SoundRecorder::getAvailableDevices();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too < and > need to be escaped. =P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@eXpl0it3r
Copy link
Member

Feel free to squash the two commits. 😉

@@ -72,6 +72,36 @@
If you want to use the captured audio data after the recorder is destroyed or restarted, don't forget to make a <em>copy</em> of the buffer.
</p>

<?php h2('Selecting the input device') ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sélectionner le périphérique d'entrée

@mantognini
Copy link
Member

Here, now you've got a translation (@LaurentGomila si tu vois des erreurs, n'hésite pas à me taper dessus =P)

@LaurentGomila
Copy link
Member

@LaurentGomila si tu vois des erreurs, n'hésite pas à me taper dessus =P

I edited your messages directly. You made the initial translation effort, so... I won't bash you this time.

Seriously, there were only a few minor mistakes, good job ;)

@Foaly
Copy link
Contributor Author

Foaly commented Sep 28, 2015

Awesome! Thank you guys for the translation 👍. I will add it tomorrow and squash everything into one commit. Then it should be ready for a final review.

@mantognini
Copy link
Member

@LaurentGomila haha thank you! :D

@Foaly
Copy link
Contributor Author

Foaly commented Sep 29, 2015

Ok I added the french translation and squased the commit. I added an error check to the example. But I don't know if I got the french translation right... 😃 erreur: sélection du périphérique ratée
But other than that everything should be fine now.

@LaurentGomila
Copy link
Member

"ratée" is too familiar for this context.

erreur : échec de sélection du périphérique

(don't forget the extra space before the colon)

Also added a section about selection of the input device. French translation by mantognini.
@Foaly
Copy link
Contributor Author

Foaly commented Sep 29, 2015

Ok thanks. I fixed it.
It should be ready for merging now.

@eXpl0it3r eXpl0it3r merged commit 08e0b6e into SFML:master Sep 29, 2015
@eXpl0it3r eXpl0it3r self-assigned this Sep 29, 2015
@Foaly Foaly deleted the patch-1 branch September 29, 2015 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants