Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFML installs extlibs even if SFML_USE_SYSTEM_DEPS is set #1236

Closed
hanetzer opened this issue Jun 2, 2017 · 2 comments · Fixed by #1237
Closed

SFML installs extlibs even if SFML_USE_SYSTEM_DEPS is set #1236

hanetzer opened this issue Jun 2, 2017 · 2 comments · Fixed by #1237
Assignees
@MarioLiebisch
Labels
bug m:config s:superseded
Projects
SFML 2.5.0
Milestone
2.5

Comments

@hanetzer
Copy link
Contributor

hanetzer commented Jun 2, 2017

Some people have a sane-ish setup which already includes properly compiled vorbis, openal, etc
and sfml can clobber those libraries when compiled for windows.

Add a flag to prevent this for those with this sort of setup.
@hanetzer
Copy link
Contributor Author

hanetzer commented Jun 2, 2017

Also, I do see SFML_USE_SYSTEM_DEPS, but this does not work, when either TRUE or FALSE, as all those libraries get installed regardless.

@MarioLiebisch
Copy link
Member

Was about to suggest SFML_USE_SYSTEM_DEPS. How about rewording the issue then?

@hanetzer hanetzer mentioned this issue Jun 2, 2017
Merged
@eXpl0it3r eXpl0it3r changed the title Add a flag to cmake build to prevent building/including external deps. SFML installs extlibs even if SFML_USE_SYSTEM_DEPS is set Jun 2, 2017
@eXpl0it3r eXpl0it3r added this to the 2.5 milestone Jun 3, 2017
@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.5.0 Jun 3, 2017
@eXpl0it3r eXpl0it3r moved this from Discussion to Ready in SFML 2.5.0 Jun 3, 2017
@eXpl0it3r eXpl0it3r moved this from Ready to Merged in SFML 2.5.0 Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarioLiebisch MarioLiebisch

Labels
bug m:config s:superseded
Projects
No open projects
SFML 2.5.0
  
Merged / Superseded
Milestone
2.5
Development

Successfully merging a pull request may close this issue.

Do not install extlibs if SFML_USE_SYSTEM_DEPS is true. hanetzer/SFML
3 participants
@eXpl0it3r @MarioLiebisch @hanetzer