Remove defaulted or empty, non-virtual destructors #2312

[benjamintli]

Thanks a lot for making a contribution to SFML! 🙂

Before you create the pull request, we ask you to check the follow boxes. (For small changes not everything needs to ticked, but the more the better!)

• Has this change been discussed on the forum or in an issue before?
• Does the code follow the SFML Code Style Guide?
• Have you provided some example/test code for your changes?
• If you have additional steps which need to be performed list them as tasks!

---

Description

Please describe your pull request.

resolves #2312

Tasks

• Tested on Linux
• Tested on Windows
• Tested on macOS
• Tested on iOS
• Tested on Android

[codecov]

Codecov Report

Merging #2321 (dc8bec1) into master (7884efc) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #2321    +/-   ##
========================================
  Coverage   14.64%   14.64%            
========================================
  Files         214      216     +2     
  Lines       15106    15106            
  Branches     4029     4029            
========================================
  Hits         2212     2212            
+ Misses      12761    12550   -211     
- Partials      133      344   +211     

Impacted Files	Coverage Δ
include/SFML/Network/SocketSelector.hpp	0.00% <ø> (ø)
include/SFML/Window/Cursor.hpp	0.00% <ø> (ø)
src/SFML/Graphics/Shader.cpp	0.19% <ø> (ø)
src/SFML/Network/SocketSelector.cpp	0.00% <ø> (ø)
src/SFML/Window/Cursor.cpp	0.00% <ø> (ø)
src/SFML/Audio/Music.cpp	0.00% <0.00%> (ø)
src/SFML/Audio/Sound.cpp	0.00% <0.00%> (ø)
src/SFML/Network/Ftp.cpp	0.00% <0.00%> (ø)
src/SFML/Network/Http.cpp	74.50% <0.00%> (ø)
src/SFML/Audio/ALCheck.cpp	0.00% <0.00%> (ø)
... and 56 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7884efc...dc8bec1. Read the comment docs.

Premature approval

[ChrisThrasher]

#2312 (comment)

@kimci86 made a great point in the issue thread how this type needs an explicitly declared destructor given how it's being implemented. I was able to corroborate this by simply attempting to construct an instead of sf::Cursor and see the build fail. I think coincidentally this passed CI because an sf::Cursor is never constructed (and thus destroyed) anywhere in the repo itself so we were able to omit a destructor without that issue being detected.

[ChrisThrasher]

I'm closing this PR since we can't easily remove these destructors after all.