New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Geometry Shader #428

Closed
Mrowqa opened this Issue Jul 16, 2013 · 2 comments

Comments

Projects
None yet
5 participants
@Mrowqa
Contributor

Mrowqa commented Jul 16, 2013

It could be done like sf::RenderStates. You can keep method for one type of shader and write second method for all three types - if you don't want one of types you can simply pass empty string/stream (add sf::EmptyStream?). If one of shader's type won't be supported - you can simply fail loadFromXXX method - programmer should check which shaders are available before using them.

For checking which shaders are available you can simply modify existing method:
static bool isAvailable (Type shaderType);
Not bad idea is make it with binary flags.

@ghost ghost assigned LaurentGomila Jul 16, 2013

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 21, 2013

It may be worth pointing out that the open-source mesa stack on Linux doesn't support geometry shaders, yet. So, it'd require proprietary drivers.

ghost commented Jul 21, 2013

It may be worth pointing out that the open-source mesa stack on Linux doesn't support geometry shaders, yet. So, it'd require proprietary drivers.

@LaurentGomila LaurentGomila removed their assignment May 19, 2014

@binary1248 binary1248 self-assigned this Aug 14, 2014

@binary1248 binary1248 added s:accepted and removed s:unassigned labels Aug 14, 2014

@eXpl0it3r eXpl0it3r removed this from the 2.x milestone Nov 13, 2014

@Mrowqa Mrowqa removed this from the 2.x milestone Nov 13, 2014

@binary1248 binary1248 added this to the 2.4 milestone Mar 29, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Feb 19, 2016

Member

Merged in 146f638

Member

eXpl0it3r commented Feb 19, 2016

Merged in 146f638

@eXpl0it3r eXpl0it3r closed this Feb 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment