Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS build defaults to x86_64 architecture, regardless of specified platform #1373

Closed
JonnyPtn opened this issue Feb 24, 2018 · 2 comments · Fixed by #1377
Closed

iOS build defaults to x86_64 architecture, regardless of specified platform #1373

JonnyPtn opened this issue Feb 24, 2018 · 2 comments · Fixed by #1377

Comments

@JonnyPtn
Copy link
Contributor

See discussion here

as the toolchain file is processed when project(SFML) is called, it doesn't overwrite the previous setting of CMAKE_OSX_ARCHITECTURES, configured here

Not 100% sure of the best way to fix this. @Ceylo fixed it by checking if a toolchain file is being used, which will work, but I think there should be a better way.

I also found that moving the call to project() to be above that block of Code also fixes it, and doesn't have any adverse effects on osx builds, however the
docs indicate it must be set before the first call to project(), so I'm reluctant to do that

@Ceylo
Copy link
Contributor

Ceylo commented Feb 24, 2018

Anotherpossible way is to force updating the cache entry in the toolcgain file. This means the user will be unable to change the architecture in CMake GUI but that may be ok as it’ll most likely not be needed anytime soon.

@JonnyPtn
Copy link
Contributor Author

That actually sounds like a decent solution - the architecture in the toolchain is determined by the IOS_PLATFORM variable, which the user can modify so it wouldn't really restrict anything

@JonnyPtn JonnyPtn mentioned this issue Mar 6, 2018
@eXpl0it3r eXpl0it3r added this to Discussion in SFML 2.5.0 via automation Mar 26, 2018
@eXpl0it3r eXpl0it3r added this to the 2.5 milestone Mar 26, 2018
@eXpl0it3r eXpl0it3r moved this from Discussion to Merged / Superseded in SFML 2.5.0 Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
SFML 2.5.0
  
Merged / Superseded
Development

Successfully merging a pull request may close this issue.

3 participants