sf::cursor.loadFromPixels doesn't work.

[Neko-Box-Coder]

sf::cursor.loadFromPixels doesn't work.

sf::cursor.loadFromPixels is not showing anything (invisible cursor) despite it being set and returned true.

Note that this works on 2.5.1 (Monochrome) but not 3.0.0 (latest snapshot) at least on my machine, any confirmation on other Linux machines will be appreciated.

If there's anything needed, just message me and I will replay asap.

Your environment

• Arch (5.15.28-1 kernel) with Xorg
• Latest snapshot (Date of issue)
• GCC (Unix) with CMake
• set(SFML_STATIC_LIBRARIES TRUE)

Steps to reproduce

#include <iostream> 
#include "SFML/Graphics.hpp"
#include "SFML/Window.hpp"

int main()
{
    sf::RenderWindow window(sf::VideoMode(200, 200), "SFML works!");
    sf::CircleShape shape(100.f);
    shape.setFillColor(sf::Color::Green);

    sf::Cursor SFMLCursor;

    uint8_t TempCursor[256] =
    {
        0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,
        0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,
        0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,
        0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,
        0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,
        0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,
        0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,
        0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255,       0, 0, 0, 255
    };


    if(!SFMLCursor.loadFromPixels(&TempCursor[0], sf::Vector2u(8, 8), sf::Vector2u()))
        std::cout<<"Failed to load cursor\n";

    // if(!SFMLCursor.loadFromSystem(sf::Cursor::Type::Hand))
    //     std::cout<<"Failed to load cursor\n";

    window.setMouseCursor(SFMLCursor);

    while (window.isOpen())
    {
        sf::Event event;
        while (window.pollEvent(event))
        {
            if (event.type == sf::Event::Closed)
                window.close();
        }

        window.clear(sf::Color(255, 255, 255, 255));
        window.draw(shape);
        window.display();
    }

    return 0;
}

Expected behavior

It should show the cursor as a black 8x8 image.

Actual behavior

The cursor is invisible instead.

[eXpl0it3r]

Can you give the 2.6.x branch a try, so we can check whether it's a regression in SFML 3 or already came with SFML 2.6?

[Neko-Box-Coder]

I just tried 2.6.x from the snapshot. It is the same result

[eXpl0it3r]

The same bad (3.0.0 behavior) or same good (2.5.1 behavior) result? 😄

[Neko-Box-Coder]

Yeah sorry, I mean same result as 3.0.0 haha.

[ChrisThrasher]

Are you able to bisect the commit history to find the exact commit which introduced the problem? That would be really helpful to know.

[texus]

It looks like the bug was introduced in e0f2356
The version before that commit still showed the cursor, and with that commit the cursor is no longer visible.

[kimci86]

This fixes the issue for me (branch 2.6.x):

diff --git a/src/SFML/Window/Unix/CursorImpl.cpp b/src/SFML/Window/Unix/CursorImpl.cpp
index d0d51300..f2cfdf80 100644
--- a/src/SFML/Window/Unix/CursorImpl.cpp
+++ b/src/SFML/Window/Unix/CursorImpl.cpp
@@ -80,10 +80,10 @@ bool CursorImpl::loadFromPixelsARGB(const Uint8* pixels, Vector2u size, Vector2u
     const std::size_t numPixels = size.x * size.y;
     for (std::size_t pixelIndex = 0; pixelIndex < numPixels; ++pixelIndex)
     {
-        cursorImage->pixels[pixelIndex] = static_cast<Uint8>(pixels[pixelIndex * 4 + 2] +
-                                                            (pixels[pixelIndex * 4 + 1] << 8) +
-                                                            (pixels[pixelIndex * 4 + 0] << 16) +
-                                                            (pixels[pixelIndex * 4 + 3] << 24));
+        cursorImage->pixels[pixelIndex] = static_cast<Uint32>(pixels[pixelIndex * 4 + 2] +
+                                                              (pixels[pixelIndex * 4 + 1] << 8) +
+                                                              (pixels[pixelIndex * 4 + 0] << 16) +
+                                                              (pixels[pixelIndex * 4 + 3] << 24));
     }
 
     // Create the cursor.

[eXpl0it3r]

@Neko-Box-Coder, can you confirm that the merge fix (#2073) onto 2.6.x fixes the problem?

[Neko-Box-Coder]

@eXpl0it3r Thanks a lot, I can confirm it fixed the problem. Will this be merged to master at some point?

[eXpl0it3r]

Yes, might wait for some other 2.6.x PR, but if those don't come through soon, then I'll do another back merge.