Add more clang-tidy checks

.clang-tidy

@@ -1,5 +1,4 @@
 Checks: >
-  -*,
   bugprone-*,
   clang-analyzer-*,
   concurrency-*,
@@ -9,13 +8,10 @@ Checks: >
   performance-*,
   portability-*,
   readability-*,
-  -bugprone-branch-clone,
   -bugprone-easily-swappable-parameters,
   -cppcoreguidelines-avoid-c-arrays,
   -cppcoreguidelines-avoid-magic-numbers,
   -cppcoreguidelines-avoid-non-const-global-variables,
-  -cppcoreguidelines-owning-memory,
-  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
   -cppcoreguidelines-pro-bounds-constant-array-index,
   -cppcoreguidelines-pro-bounds-pointer-arithmetic,
   -cppcoreguidelines-pro-type-cstyle-cast,
@@ -26,7 +22,6 @@ Checks: >
   -modernize-use-trailing-return-type,
   -performance-no-int-to-ptr,
   -readability-braces-around-statements,
-  -readability-function-cognitive-complexity,
   -readability-identifier-length,
   -readability-implicit-bool-conversion,
   -readability-magic-numbers,
@@ -36,6 +31,7 @@ CheckOptions:
   - { key: readability-identifier-naming.NamespaceCase,       value: CamelCase  }
   - { key: readability-identifier-naming.MemberCase,          value: camelBack  }
   - { key: readability-identifier-naming.PrivateMemberCase,   value: camelBack  }
+  - { key: readability-function-cognitive-complexity.Threshold, value: 40 }
 HeaderFilterRegex: '(./imgui-SFML*)'
 WarningsAsErrors: '*'
 UseColor: true

imgui-SFML.cpp

@@ -22,6 +22,7 @@
 #include <cstring> // memcpy
 
 #include <algorithm>
+#include <array>
 #include <memory>
 #include <vector>
 
@@ -866,12 +867,12 @@ void RenderDrawLists(ImDrawData* draw_data) {
     // Backup GL state
     GLint last_texture = 0;
     glGetIntegerv(GL_TEXTURE_BINDING_2D, &last_texture);
-    GLint last_polygon_mode[2];
-    glGetIntegerv(GL_POLYGON_MODE, last_polygon_mode);
-    GLint last_viewport[4];
-    glGetIntegerv(GL_VIEWPORT, last_viewport);
-    GLint last_scissor_box[4];
-    glGetIntegerv(GL_SCISSOR_BOX, last_scissor_box);
+    std::array<GLint, 2> last_polygon_mode{};
+    glGetIntegerv(GL_POLYGON_MODE, last_polygon_mode.data());
+    std::array<GLint, 4> last_viewport{};
+    glGetIntegerv(GL_VIEWPORT, last_viewport.data());
+    std::array<GLint, 4> last_scissor_box{};
+    glGetIntegerv(GL_SCISSOR_BOX, last_scissor_box.data());
     GLint last_shade_model = 0;
     glGetIntegerv(GL_SHADE_MODEL, &last_shade_model);
     GLint last_tex_env_mode = 0;